Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Install MLIR Python requirements on buildbot workers
Needs ReviewPublic

Authored by ftynse on Jan 19 2022, 10:17 AM.



MLIR Python interface has its requirements listed in the repository, but
they are not necessarily available on the buildbot workers. Add an extra
step of installing these requirements using pip. Wrap the entire process
into a new MLIR build factory that adds the step, if requested, after
checking out the source and before running cmake.

Event Timeline

ftynse created this revision.Jan 19 2022, 10:17 AM
ftynse requested review of this revision.Jan 19 2022, 10:17 AM


I'll let Galina do the review, I'm never totally sure about the buildbot code.

Galina: does it look good to you?

Thanks for the patch, Alex!


This would build you a path according to the rules of the OS buildbot master is running on. But you need the path for the worker, which could run a different OS. It is unlikely that we would run the main buildbot on Windows, but still.

Having it as mlir/python/requirements.txt is fine here.


Did you forget to import getCmakeWithNinjaBuildFactory? Or, if I guessed right, you wanted to use getLLVMBuildFactoryAndSourcecodeSteps here instead?

I'm happy to get this across the finish line in order to get mlir-python builders back. @gkistanova Is there a brief description somewhere for how to test this code locally?

Hi Maksim,

We can stage this patch after you will address my comments. That would be the easiest way to the result.