Add TACO tests to test/Integration/Dialect/SparseTensor/taco. Add the MLIR
PyTACO implementation as tools under the directory.
Details
- Reviewers
aartbik - Commits
- rG778a264da9eb: Upstream MLIR PyTACO implementation.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Shall we add a README to the taco directory with some background information, i.e. link to TACO website, and brief explanation of PyTACO?
A README.md still shows up more prominent when looking at the source tree under e.g. github
mlir/test/Integration/Dialect/SparseTensor/taco/MTTKRP_test.py | ||
---|---|---|
4–6 | There are quite a few modifications around the core. Can you move this comment to the exact place where we use the original TACO part, so <code> This PyTACO part is taken from the TACO open-source project.PyTaco <code> | |
32–35 | please do not use commented out code; the test should run as is, and the comment should reflect what is done; if we want to test the other cases too, we should add more tests | |
mlir/test/Integration/Dialect/SparseTensor/taco/SpMV_test.py | ||
4 | same, make it very specific what kernel part is from PyTACO example | |
33–36 | remove commented out code | |
mlir/test/Integration/Dialect/SparseTensor/taco/tools/mlir_pytaco.py | ||
23 | empty line after from |
Address review feedback.
mlir/test/Integration/Dialect/SparseTensor/taco/MTTKRP_test.py | ||
---|---|---|
32–35 | Remove this comment. |
Few last nits.
Also, as some background for others, indeed this code is "upstreamed" so I have seen most of the python bridge before.
Others may want to chime in on style or content, but even though it is a large drop, it has been reviewed earlier.
mlir/test/Integration/Dialect/SparseTensor/taco/MTTKRP_test.py | ||
---|---|---|
30 | Modify - >This line has been modified from the original program to .... | |
mlir/test/Integration/Dialect/SparseTensor/taco/README.md | ||
13 | machine code -> an executable, or runnable code or something like that? | |
mlir/test/Integration/Dialect/SparseTensor/taco/SpMV_test.py | ||
31 | Modify - >This line has been modified from the original program to .... | |
mlir/test/Integration/Dialect/SparseTensor/taco/simple_tensor_algebra_test.py | ||
29 | maybe empty line before this CHECK |
mlir/test/Integration/Dialect/SparseTensor/taco/README.md | ||
---|---|---|
9 |
mlir/test/Integration/Dialect/SparseTensor/taco/README.md | ||
---|---|---|
13 | machine code -> an executable |
I reverted because this broke the bot testing: https://lab.llvm.org/buildbot/#/builders/61/builds/20064
There are quite a few modifications around the core. Can you move this comment to the exact place where we use the original TACO part, so
<code>
This PyTACO part is taken from the TACO open-source project.
PyTaco
<code>