This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Fix compilation with LLVM_ENABLE_THREADS=OFF
ClosedPublic

Authored by jdd on Jan 7 2022, 5:03 PM.

Details

Summary

Currently, compiles with LLVM_ENABLE_THREADS=OFF fail due to this symbol missing. Add it but assert as calling code is (and should be) checking that threading is enabled.

Diff Detail

Event Timeline

jdd created this revision.Jan 7 2022, 5:03 PM
jdd requested review of this revision.Jan 7 2022, 5:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 7 2022, 6:21 PM
This revision was automatically updated to reflect the committed changes.
dexonsmith added inline comments.Jan 10 2022, 6:43 PM
llvm/lib/Support/ThreadPool.cpp
121

Perhaps llvm::report_fatal_error() would be appropriate here.

MaskRay added inline comments.
llvm/lib/Support/ThreadPool.cpp
121

There was a -Wreturn-type warning in -DLLVM_ENABLE_THREADS=OFF -DLLVM_ENABLE_ASSERTIONS=off build.

Fixed by 27cb5eea00a8841323f16d5914d9dec29eb03ef7