[RISCV] [NFC] Delete duplicate judgments in InsertVSETVLI

[Chenbing.Zheng]

Summary

Delete duplicate judgments and move a scene into hasCompatibleVTYPE.

[craig.topper]

There are 3 callers of hasCompatibleVTYPE. This code previously existed in one of them. Moving it affects the other 2 callers. Is this patch really NFC?

[Chenbing.Zheng]

In D116796#3227873, @craig.topper wrote:

There are 3 callers of hasCompatibleVTYPE. This code previously existed in one of them. Moving it affects the other 2 callers. Is this patch really NFC?

It is my mistake, I will think more about it.

llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp

public:
   bool hasCompatibleVTYPE(const VSETVLIInfo &InstrInfo, bool Strict) const {
     // Simple case, see if full VTYPE matches.
     if (hasSameVTYPE(InstrInfo))
       return true;
 
     if (Strict)
       return false;
 
+    // Store instructions don't use the policy fields.
+    if (InstrInfo.StoreOp && VLMul == InstrInfo.VLMul && SEW == InstrInfo.SEW)
+      return true;
+
     // If this is a mask reg operation, it only cares about VLMAX.
     // FIXME: Mask reg operations are probably ok if "this" VLMAX is larger
     // than "InstrInfo".
     // FIXME: The policy bits can probably be ignored for mask reg operations.
     if (InstrInfo.MaskRegOp && hasSameVLMAX(InstrInfo) &&
         TailAgnostic == InstrInfo.TailAgnostic &&
         MaskAgnostic == InstrInfo.MaskAgnostic)
       return true;
bool isCompatible(const VSETVLIInfo &InstrInfo, bool Strict) const {
 
     // The AVL must match.
     if (!hasSameAVL(InstrInfo))
       return false;
 
     if (hasCompatibleVTYPE(InstrInfo, Strict))
       return true;
 
-    // Strict matches must ensure a full VTYPE match.
-    if (Strict)
-      return false;
-
-    // Store instructions don't use the policy fields.
-    // TODO: Move into hasCompatibleVTYPE?
-    if (InstrInfo.StoreOp && VLMul == InstrInfo.VLMul && SEW == InstrInfo.SEW)
-      return true;
-
     // Anything else is not compatible.
     return false;
   }
 
   bool isCompatibleWithLoadStoreEEW(unsigned EEW,
                                     const VSETVLIInfo &InstrInfo) const {
     assert(isValid() && InstrInfo.isValid() &&
            "Can't compare invalid VSETVLIInfos");