Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang-tools-extra/clangd/refactor/Rename.cpp | ||
---|---|---|
163 | nit: "as renaming these symbols..." | |
164 | nit: "unlikely to be good candidates for modification" Maybe my wording is bad, too, but what I want to convey is that the problem isn't that they can't be modified but that we don't want them to be modified! | |
171 | Any reason not to do this right now? (if we keep the comment, then it's probably better as "Remove this check because it is redundant in the presence of isInSystemHeader") |
clang-tools-extra/clangd/unittests/RenameTests.cpp | ||
---|---|---|
1202 | Nit: capitalization. |
remove accident changes.
clang-tools-extra/clangd/refactor/Rename.cpp | ||
---|---|---|
171 | We could do it in this patch, I slightly prefer to do it in a followup patch, it'd require some changes in the unittests. (this FIXME was added in the last minute -- at the very beginning I didn't notice that it could be simplified) |
LG, thanks!
clang-tools-extra/clangd/refactor/Rename.cpp | ||
---|---|---|
171 | Okay, makes sense, thanks for explaining! |
nit: "as renaming these symbols..."