This is an archive of the discontinued LLVM Phabricator instance.

Differential D116357

Demo fix for modernize-use-using (WIP)
ClosedPublic

Authored by mehdi_amini on Dec 28 2021, 9:52 PM.

Details

Reviewers
rriddle
Mogball
aartbik
Commits
rGb11510d5dfaf: Apply clang-tidy fixes for modernize-use-using to MLIR (NFC)

Diff Detail

Event Timeline

mehdi_amini created this revision.Dec 28 2021, 9:52 PM
Herald added a reviewer: aartbik. · View Herald TranscriptDec 28 2021, 9:52 PM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 18 others. · View Herald Transcript
mehdi_amini requested review of this revision.Dec 28 2021, 9:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2021, 9:52 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B140848: Diff 396471.Dec 28 2021, 10:20 PM
Mogball accepted this revision.Dec 29 2021, 8:47 AM
This revision is now accepted and ready to land.Dec 29 2021, 8:47 AM
rriddle accepted this revision.Jan 1 2022, 3:28 AM
Closed by commit rGb11510d5dfaf: Apply clang-tidy fixes for modernize-use-using to MLIR (NFC) (authored by mehdi_amini). · Explain WhyJan 1 2022, 5:25 PM
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rGb11510d5dfaf: Apply clang-tidy fixes for modernize-use-using to MLIR (NFC).

Revision Contents

PathSize
mlir/
lib/
ExecutionEngine/
2 lines

Diff 396471

mlir/lib/ExecutionEngine/SparseTensorUtils.cpp

Show First 20 Lines • Show All 685 Lines • ▼ Show 20 Lines
extern "C" { extern "C" {
/// This type is used in the public API at all places where MLIR expects /// This type is used in the public API at all places where MLIR expects
/// values with the built-in type "index". For now, we simply assume that /// values with the built-in type "index". For now, we simply assume that
/// type is 64-bit, but targets with different "index" bit widths should link /// type is 64-bit, but targets with different "index" bit widths should link
/// with an alternatively built runtime support library. /// with an alternatively built runtime support library.
// TODO: support such targets? // TODO: support such targets?
typedef uint64_t index_t; using index_t = uint64_t;
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Public API with methods that operate on MLIR buffers (memrefs) to interact // Public API with methods that operate on MLIR buffers (memrefs) to interact
// with sparse tensors, which are only visible as opaque pointers externally. // with sparse tensors, which are only visible as opaque pointers externally.
// These methods should be used exclusively by MLIR compiler-generated code. // These methods should be used exclusively by MLIR compiler-generated code.
// //
// Some macro magic is used to generate implementations for all required type // Some macro magic is used to generate implementations for all required type
▲ Show 20 Lines • Show All 428 Lines • Show Last 20 Lines