This is an archive of the discontinued LLVM Phabricator instance.

Differential D116046

[mlir] Add `mlir/unittests/BUILD.bazel`
ClosedPublic

Authored by Mogball on Dec 20 2021, 8:46 AM.

Details

Reviewers
mehdi_amini
jpienaar
GMNGeoffrey
Commits
rG07b073c1bbb6: [mlir] Add `mlir/unittests/BUILD.bazel`
Summary

Unit tests are not getting built as part of bazel runs.

Diff Detail

Event Timeline

Mogball created this revision.Dec 20 2021, 8:46 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 20 others. · View Herald TranscriptDec 20 2021, 8:46 AM
Mogball requested review of this revision.Dec 20 2021, 8:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2021, 8:46 AM
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B140102: Diff 395466.Dec 20 2021, 8:52 AM
Mogball added reviewers: mehdi_amini, jpienaar.Dec 20 2021, 11:02 AM
mehdi_amini accepted this revision.Dec 20 2021, 11:15 AM
mehdi_amini added a reviewer: GMNGeoffrey.
This revision is now accepted and ready to land.Dec 20 2021, 11:15 AM
mehdi_amini added a comment.Dec 20 2021, 11:15 AM

Please wait for @GMNGeoffrey approval :)

GMNGeoffrey added inline comments.Dec 20 2021, 11:20 AM
utils/bazel/llvm-project-overlay/mlir/unittests/BUILD.bazel
2

Please add the license header as in other build files. Also, the "Description:" seems not very useful and the description itself honestly doesn't say anything that the filepath doesn't. I'd just delete both

GMNGeoffrey accepted this revision.Dec 20 2021, 11:40 AM

Other than that, LGTM

Mogball updated this revision to Diff 395520.Dec 20 2021, 1:40 PM

Fix description

Mogball marked an inline comment as done.Dec 20 2021, 1:41 PM
This revision was landed with ongoing or failed builds.Dec 20 2021, 1:41 PM
Closed by commit rG07b073c1bbb6: [mlir] Add `mlir/unittests/BUILD.bazel` (authored by Mogball). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mogball added a commit: rG07b073c1bbb6: [mlir] Add `mlir/unittests/BUILD.bazel`.
Harbormaster completed remote builds in B140134: Diff 395520.Dec 20 2021, 1:45 PM

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
mlir/
unittests/
270 lines

Diff 395521

utils/bazel/llvm-project-overlay/mlir/unittests/BUILD.bazel

  • This file was added.
# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information.
GMNGeoffreyUnsubmitted
Done
ReplyInline Actions

Please add the license header as in other build files. Also, the "Description:" seems not very useful and the description itself honestly doesn't say anything that the filepath doesn't. I'd just delete both

GMNGeoffrey: Please add the license header as in other build files. Also, the "Description:" seems not very…
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
load("//mlir:tblgen.bzl", "gentbl_cc_library")
package(
default_visibility = ["//visibility:public"],
licenses = ["notice"],
)
cc_test(
name = "ir_tests",
size = "small",
srcs = glob([
"IR/*.cpp",
"IR/*.h",
]),
deps = [
"//llvm:TestingSupport",
"//llvm:gtest_main",
"//mlir:IR",
"//mlir/test:TestDialect",
],
)
cc_test(
name = "interface_tests",
size = "small",
srcs = glob([
"Interfaces/*.cpp",
"Interfaces/*.h",
]),
deps = [
"//llvm:TestingSupport",
"//llvm:gtest_main",
"//mlir:ControlFlowInterfaces",
"//mlir:DLTIDialect",
"//mlir:DataLayoutInterfaces",
"//mlir:IR",
"//mlir:InferTypeOpInterface",
"//mlir:Parser",
"//mlir:StandardOps",
],
)
cc_test(
name = "support_tests",
size = "small",
srcs = glob([
"Support/*.cpp",
"Support/*.h",
]),
deps = [
"//llvm:Support",
"//llvm:TestingSupport",
"//llvm:gtest_main",
"//mlir:Support",
],
)
cc_test(
name = "pass_tests",
size = "small",
srcs = glob([
"Pass/*.cpp",
"Pass/*.h",
]),
deps = [
"//llvm:TestingSupport",
"//llvm:gtest_main",
"//mlir:Analysis",
"//mlir:IR",
"//mlir:Pass",
],
)
cc_test(
name = "dialect_tests",
size = "small",
srcs = glob([
"Dialect/*.cpp",
"Dialect/*.h",
]),
deps = [
"//llvm:TestingSupport",
"//llvm:gtest_main",
"//mlir:Dialect",
],
)
cc_test(
name = "quantops_tests",
size = "small",
srcs = glob([
"Dialect/Quant/*.cpp",
"Dialect/Quant/*.h",
]),
deps = [
"//llvm:TestingSupport",
"//llvm:gtest_main",
"//mlir:QuantOps",
"//mlir:Transforms",
],
)
cc_test(
name = "sparse_tensor_tests",
size = "small",
srcs = glob([
"Dialect/SparseTensor/*.cpp",
"Dialect/SparseTensor/*.h",
]),
deps = [
"//llvm:TestingSupport",
"//llvm:gtest_main",
"//mlir:SparseTensorUtils",
],
)
cc_test(
name = "spirv_tests",
size = "small",
srcs = glob([
"Dialect/SPIRV/*.cpp",
"Dialect/SPIRV/*.h",
]),
deps = [
"//llvm:TestingSupport",
"//llvm:gtest_main",
"//mlir:SPIRVDeserialization",
"//mlir:SPIRVDialect",
"//mlir:SPIRVSerialization",
],
)
cc_test(
name = "dialect_utils_tests",
size = "small",
srcs = glob([
"Dialect/Utils/*.cpp",
"Dialect/Utils/*.h",
]),
deps = [
"//llvm:TestingSupport",
"//llvm:gtest_main",
"//mlir:DialectUtils",
],
)
gentbl_cc_library(
name = "EnumsIncGen",
tbl_outs = [
(
["-gen-enum-decls"],
"TableGen/EnumsGenTest.h.inc",
),
(
["-gen-enum-defs"],
"TableGen/EnumsGenTest.cpp.inc",
),
],
tblgen = "//mlir:mlir-tblgen",
td_file = "TableGen/enums.td",
deps = [
"//mlir:OpBaseTdFiles",
],
)
gentbl_cc_library(
name = "PassIncGen",
tbl_outs = [
(
["-gen-pass-decls"],
"TableGen/PassGenTest.h.inc",
),
],
tblgen = "//mlir:mlir-tblgen",
td_file = "TableGen/passes.td",
deps = [
"//mlir:PassBaseTdFiles",
"//mlir:RewritePassBaseTdFiles",
],
)
gentbl_cc_library(
name = "StructsIncGen",
tbl_outs = [
(
["-gen-struct-attr-decls"],
"TableGen/StructAttrGenTest.h.inc",
),
(
["-gen-struct-attr-defs"],
"TableGen/StructAttrGenTest.cpp.inc",
),
],
tblgen = "//mlir:mlir-tblgen",
td_file = "TableGen/structs.td",
deps = [
"//mlir:OpBaseTdFiles",
],
)
cc_test(
name = "tablegen_tests",
size = "small",
srcs = glob([
"TableGen/*.cpp",
"TableGen/*.h",
]) + [
"TableGen/EnumsGenTest.cpp.inc",
"TableGen/EnumsGenTest.h.inc",
"TableGen/StructAttrGenTest.cpp.inc",
"TableGen/StructAttrGenTest.h.inc",
],
includes = ["TableGen/"],
deps = [
":EnumsIncGen",
":PassIncGen",
":StructsIncGen",
"//llvm:Support",
"//llvm:TestingSupport",
"//llvm:gtest_main",
"//mlir:IR",
"//mlir:TableGen",
"//mlir/test:TestDialect",
],
)
cc_test(
name = "analysis_tests",
size = "small",
srcs = glob([
"Analysis/*.cpp",
"Analysis/*.h",
"Analysis/*/*.cpp",
"Analysis/*/*.h",
]),
deps = [
"//llvm:TestingSupport",
"//llvm:gtest_main",
"//mlir:Analysis",
"//mlir:IR",
],
)
cc_test(
name = "execution_engine_tests",
size = "small",
srcs = glob([
"ExecutionEngine/*.cpp",
]),
tags = [
# MSAN does not work with JIT.
"nomsan",
],
deps = [
"//llvm:TestingSupport",
"//llvm:gtest_main",
"//mlir:AllPassesAndDialects",
"//mlir:Analysis",
"//mlir:ExecutionEngine",
"//mlir:IR",
"//mlir:LinalgToLLVM",
"//mlir:MemRefToLLVM",
"//mlir:mlir_c_runner_utils",
"//mlir:mlir_runner_utils",
],
)