The run line of stack-protector-guard.c doesn't specify the triple, which means it depends on the platform running the test. This makes some failure hidden.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
| Time | Test | |
|---|---|---|
| 50 ms | x64 debian > LLVM.Bindings/Go::go.test |
Event Timeline
Comment Actions
Thanks for the patch. You're right about this change, sorry I made the mistake!
| clang/test/CodeGen/stack-protector-guard.c | ||
|---|---|---|
| 1–12 | sp_el0 doesn't make sense for these targets; it's an aarch64 specific MSR. Let's delete these lines from the test? | |
| 16 | x86_64-linux-gnu | |
| 16–23 | Or let's just delete these? | |
| 20 | arm-linux-gnueabi | |
| 22 | thumbv7-linux-gnueabi | |
sp_el0 doesn't make sense for these targets; it's an aarch64 specific MSR. Let's delete these lines from the test?