This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Specify targets for clang stack-protector-guard.c
ClosedPublic

Authored by qiucf on Dec 19 2021, 9:04 AM.

Details

Summary

The run line of stack-protector-guard.c doesn't specify the triple, which means it depends on the platform running the test. This makes some failure hidden.

Diff Detail

Unit TestsFailed

Event Timeline

qiucf requested review of this revision.Dec 19 2021, 9:04 AM
qiucf created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2021, 9:04 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Thanks for the patch. You're right about this change, sorry I made the mistake!

clang/test/CodeGen/stack-protector-guard.c
1–12

sp_el0 doesn't make sense for these targets; it's an aarch64 specific MSR. Let's delete these lines from the test?

16

x86_64-linux-gnu

16–23

Or let's just delete these?

20

arm-linux-gnueabi

22

thumbv7-linux-gnueabi

qiucf updated this revision to Diff 396379.Dec 28 2021, 12:22 AM
qiucf marked 5 inline comments as done.
nickdesaulniers accepted this revision.Dec 28 2021, 10:05 AM
This revision is now accepted and ready to land.Dec 28 2021, 10:05 AM
This revision was landed with ongoing or failed builds.Dec 29 2021, 6:15 PM
This revision was automatically updated to reflect the committed changes.