This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][FIX] Change globalization alignment to 16
ClosedPublic

Authored by jhuber6 on Dec 17 2021, 2:04 PM.

Details

Summary

This patch changes the default aligntment from 8 to 16, and encodes this
information in the __kmpc_alloc_shared runtime call to communicate it
to the HeapToStack pass. The previous alignment of 8 was not sufficient
for the maximum size of primitive types on 64-bit systems, and needs to
be increaesd. This reduces the amount of space availible in the data
sharing stack, so this implementation will need to be improved later to
include the alignment requirements in the allocation call, and use it
properly in the data sharing stack in the runtime.

Depends on D115888

Diff Detail

Unit TestsFailed

Event Timeline

jhuber6 created this revision.Dec 17 2021, 2:04 PM
jhuber6 requested review of this revision.Dec 17 2021, 2:04 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 17 2021, 2:04 PM
jdoerfert accepted this revision.Dec 27 2021, 11:39 AM

LG, partial fix for the problem and fixmes describing what needs to be done next.

This revision is now accepted and ready to land.Dec 27 2021, 11:39 AM
This revision was landed with ongoing or failed builds.Dec 27 2021, 1:58 PM
This revision was automatically updated to reflect the committed changes.