[analyzer] Enable move semantics for CallDescriptionMap

[gamesh411]

Summary

CallDescriptionMap is supposed to be immutable and opaque about the
stored CallDescriptions, but moving a CallDescriptionMap does not
violate these principles.

[steakhal]

LGTM

clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp

22

Now I get why you assert this. This is actually an NFC change, which introduces a new overload/function. It cannot change existing behavior, so we don't need to test this.

[gamesh411]

Remove static asserts as it adds little to no value in this case

clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h

public:
 
   ~CallDescriptionMap() = default;
 
   // These maps are usually stored once per checker, so let's make sure
   // we don't do redundant copies.
   CallDescriptionMap(const CallDescriptionMap &) = delete;
   CallDescriptionMap &operator=(const CallDescription &) = delete;
 
+  CallDescriptionMap(CallDescriptionMap &&) = default;
+  CallDescriptionMap &operator=(CallDescriptionMap &&) = default;
+
   LLVM_NODISCARD const T *lookup(const CallEvent &Call) const {
     // Slow path: linear lookup.
     // TODO: Implement some sort of fast path.
     for (const std::pair<CallDescription, T> &I : LinearMap)
       if (I.first.matches(Call))
         return &I.second;
 
     return nullptr;

clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp

 #include "clang/Tooling/Tooling.h"
 #include "gtest/gtest.h"
 #include <type_traits>
 
 namespace clang {
 namespace ento {
 namespace {
 
+static_assert(std::is_move_constructible<CallDescriptionMap<bool>>() &&
+                  std::is_move_assignable<CallDescriptionMap<bool>>(),
+              "CallDescriptionMap should support move semantics");
+
 // A wrapper around CallDescriptionMap<bool> that allows verifying that
 // all functions have been found. This is needed because CallDescriptionMap
 // isn't supposed to support iteration.
 class ResultMap {
   size_t Found, Total;
   CallDescriptionMap<bool> Impl;
 
 public: