This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Enable move semantics for CallDescriptionMap
ClosedPublic

Authored by gamesh411 on Dec 17 2021, 4:43 AM.

Details

Summary

CallDescriptionMap is supposed to be immutable and opaque about the
stored CallDescriptions, but moving a CallDescriptionMap does not
violate these principles.

Diff Detail

Event Timeline

gamesh411 created this revision.Dec 17 2021, 4:43 AM
gamesh411 requested review of this revision.Dec 17 2021, 4:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2021, 4:43 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
steakhal accepted this revision.Dec 17 2021, 7:00 AM

LGTM

clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp
22 ↗(On Diff #395094)

Now I get why you assert this. This is actually an NFC change, which introduces a new overload/function. It cannot change existing behavior, so we don't need to test this.

This revision is now accepted and ready to land.Dec 17 2021, 7:00 AM
gamesh411 updated this revision to Diff 395395.Dec 20 2021, 2:18 AM

Remove static asserts as it adds little to no value in this case

steakhal accepted this revision.Dec 20 2021, 2:31 AM
This revision was landed with ongoing or failed builds.Dec 20 2021, 3:16 AM
This revision was automatically updated to reflect the committed changes.