This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Generate assertions for lds-atomic-fadd.ll and local-atomics-fp.ll.
AbandonedPublic

Authored by abinavpp on Dec 16 2021, 7:36 AM.

Details

Diff Detail

Unit TestsFailed

Event Timeline

abinavpp created this revision.Dec 16 2021, 7:36 AM
abinavpp requested review of this revision.Dec 16 2021, 7:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2021, 7:36 AM
rampitec requested changes to this revision.Dec 16 2021, 11:11 AM

It also obscures what is being tested and I do not believe really needed for D115881.

llvm/test/CodeGen/AMDGPU/local-atomics-fp.ll
8

This drops coverage. There is only GFX9 here.

This revision now requires changes to proceed.Dec 16 2021, 11:11 AM
abinavpp updated this revision to Diff 395084.Dec 17 2021, 3:09 AM

Addressed review comment.

I do not believe really needed for D115881.

This is to show the change in SIInsertWaitcnts for local-atomics-fp.ll in D115881 at the moment. If we fix the problems in D115881, hopefully the regression should go away. In that case, this change is a mere test generation.

I do not believe really needed for D115881.

This is to show the change in SIInsertWaitcnts for local-atomics-fp.ll in D115881 at the moment. If we fix the problems in D115881, hopefully the regression should go away. In that case, this change is a mere test generation.

I think D115881 shall be fixed not to have that regression. Then this change is not needed too.

abinavpp abandoned this revision.Feb 24 2022, 10:44 PM

Not required for D115881.