This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Improve zeroesHigh16BitsOfDest for GFX9 legacy opcodes
ClosedPublic

Authored by foad on Dec 14 2021, 7:35 AM.

Details

Summary

Pseudos like V_MAD_U16 and V_FMA_F16 map down to what GFX9 calls
v_mad_legacy_u16 and v_fma_legacy_f16, which are documented to have the
same zeroing behaviour as on GFX8.

Diff Detail

Unit TestsFailed

Event Timeline

foad created this revision.Dec 14 2021, 7:35 AM
foad requested review of this revision.Dec 14 2021, 7:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2021, 7:35 AM
arsenm accepted this revision.Dec 14 2021, 10:38 AM

It would be nice to have end to end tests for these cases to make sure the encoding ends up OK

This revision is now accepted and ready to land.Dec 14 2021, 10:38 AM
This revision was landed with ongoing or failed builds.Dec 15 2021, 5:15 AM
This revision was automatically updated to reflect the committed changes.