Page MenuHomePhabricator

[mlir] Split std.rank into tensor.rank and memref.rank.
ClosedPublic

Authored by pifon2a on Dec 13 2021, 12:39 PM.

Details

Summary

Move std.rank similarly to how std.dim was moved to TensorOps and MemRefOps.

Diff Detail

Event Timeline

pifon2a created this revision.Dec 13 2021, 12:39 PM
pifon2a requested review of this revision.Dec 13 2021, 12:39 PM
rriddle added inline comments.Dec 13 2021, 2:24 PM
mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
1008

This still says tensor.

mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
1081–1085
mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
618–621

This could also be simplified.

mlir/test/Dialect/MemRef/invalid.mlir
850–851
mlir/test/Dialect/Tensor/invalid.mlir
298–299
nicolasvasilache accepted this revision.Dec 13 2021, 2:41 PM
This revision is now accepted and ready to land.Dec 13 2021, 2:41 PM
silvas accepted this revision.Dec 13 2021, 4:27 PM

nice :)

pifon2a updated this revision to Diff 394155.Dec 13 2021, 11:33 PM
pifon2a marked 5 inline comments as done.

Address the comments.

This revision was landed with ongoing or failed builds.Dec 14 2021, 1:16 AM
This revision was automatically updated to reflect the committed changes.