This is an archive of the discontinued LLVM Phabricator instance.

Differential D115637

[LegalizeVectorOps] typo fix
ClosedPublic

Authored by shchenz on Dec 13 2021, 7:09 AM.

Details

Reviewers
craig.topper
RKSimon
spatel
jsji
Commits
rG8c107bee702f: [LegalizeVectorOps] fix a typo
Summary

This is a typo fix introduced in D72021. This is required by D115636.

Diff Detail

Unit TestsFailed

TimeTest
110 msx64 debian > LLVM.Bindings/Go::go.test

Event Timeline

shchenz created this revision.Dec 13 2021, 7:09 AM
Herald added a subscriber: hiraditya. · View Herald TranscriptDec 13 2021, 7:09 AM
shchenz requested review of this revision.Dec 13 2021, 7:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2021, 7:09 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
shchenz added a child revision: D115636: [LegalizeVectorOps] code refactor for LegalizeOp - NFC.Dec 13 2021, 7:09 AM
shchenz mentioned this in D115636: [LegalizeVectorOps] code refactor for LegalizeOp - NFC.
Harbormaster completed remote builds in B138965: Diff 393885.Dec 13 2021, 7:51 AM
craig.topper accepted this revision.Dec 13 2021, 9:25 AM

LGTM

This revision is now accepted and ready to land.Dec 13 2021, 9:25 AM
This revision was landed with ongoing or failed builds.Dec 13 2021, 4:31 PM
Closed by commit rG8c107bee702f: [LegalizeVectorOps] fix a typo (authored by shchenz). · Explain Why
This revision was automatically updated to reflect the committed changes.
shchenz added a commit: rG8c107bee702f: [LegalizeVectorOps] fix a typo.

Revision Contents

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
2 lines

Diff 393885

llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp

Show First 20 Lines • Show All 275 Lines • ▼ Show 20 Lines if (LD->getMemoryVT().isVector() && ExtType != ISD::NON_EXTLOAD) {
} }
LLVM_FALLTHROUGH; LLVM_FALLTHROUGH;
} }
case TargetLowering::Expand: { case TargetLowering::Expand: {
Changed = true; Changed = true;
std::pair<SDValue, SDValue> Tmp = ExpandLoad(Node); std::pair<SDValue, SDValue> Tmp = ExpandLoad(Node);
AddLegalizedOperand(Op.getValue(0), Tmp.first); AddLegalizedOperand(Op.getValue(0), Tmp.first);
AddLegalizedOperand(Op.getValue(1), Tmp.second); AddLegalizedOperand(Op.getValue(1), Tmp.second);
return Op.getResNo() ? Tmp.first : Tmp.second; return Op.getResNo() ? Tmp.second : Tmp.first;
} }
} }
} }
} else if (Op.getOpcode() == ISD::STORE) { } else if (Op.getOpcode() == ISD::STORE) {
StoreSDNode *ST = cast<StoreSDNode>(Node); StoreSDNode *ST = cast<StoreSDNode>(Node);
EVT StVT = ST->getMemoryVT(); EVT StVT = ST->getMemoryVT();
MVT ValVT = ST->getValue().getSimpleValueType(); MVT ValVT = ST->getValue().getSimpleValueType();
if (StVT.isVector() && ST->isTruncatingStore()) { if (StVT.isVector() && ST->isTruncatingStore()) {
▲ Show 20 Lines • Show All 1,268 Lines • Show Last 20 Lines