This is an archive of the discontinued LLVM Phabricator instance.

[IR] Make VPIntrinsic::getDeclarationForParams() opaque pointer compatible
ClosedPublic

Authored by nikic on Dec 13 2021, 6:35 AM.

Details

Summary

The vp.load and vp.gather intrinsics require the intrinsic return type to determine the correct function signature. With opaque pointers, it cannot be derived from the parameter pointee types.

Diff Detail

Unit TestsFailed

Event Timeline

nikic created this revision.Dec 13 2021, 6:35 AM
nikic requested review of this revision.Dec 13 2021, 6:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2021, 6:35 AM

perhaps we should leave around the original version for a couple weeks and mark it deprecated so downstream users can fix usages?

perhaps we should leave around the original version for a couple weeks and mark it deprecated so downstream users can fix usages?

These are fairly recent API additions for an in-progress feature, so I was hoping that isn't necessary.

aeubanks accepted this revision.Dec 13 2021, 10:02 AM
This revision is now accepted and ready to land.Dec 13 2021, 10:02 AM

LGTM. Is this ok for RISC-V V, too?

This revision was landed with ongoing or failed builds.Dec 14 2021, 5:23 AM
This revision was automatically updated to reflect the committed changes.