This is an archive of the discontinued LLVM Phabricator instance.

Differential D115048

[LTO] Remove default_triple requirement from tests that specify the triple
ClosedPublic

Authored by Jake-Egan on Dec 3 2021, 8:30 AM.

Details

Reviewers
hubert.reinterpretcast
Commits
rG158ac4a62765: [LTO] Remove default_triple requirement from tests that specify the triple
Summary

The default_triple requirement is redundant if the test specifies the triple, so this patch removes it.

Diff Detail

Event Timeline

Jake-Egan created this revision.Dec 3 2021, 8:30 AM
Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. · View Herald TranscriptDec 3 2021, 8:30 AM
Jake-Egan requested review of this revision.Dec 3 2021, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2021, 8:30 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Jake-Egan edited the summary of this revision. (Show Details)Dec 3 2021, 8:32 AM
Jake-Egan added a reviewer: hubert.reinterpretcast.
Jake-Egan mentioned this in D114683: [LTO] Specify triple to address unknown binary format assertion.
Jake-Egan edited the summary of this revision. (Show Details)Dec 3 2021, 8:35 AM
Harbormaster completed remote builds in B137369: Diff 391656.Dec 3 2021, 9:15 AM
hubert.reinterpretcast accepted this revision.Dec 3 2021, 10:08 AM

LGTM; thanks!

This revision is now accepted and ready to land.Dec 3 2021, 10:08 AM
This revision was landed with ongoing or failed builds.Dec 8 2021, 6:17 AM
Closed by commit rG158ac4a62765: [LTO] Remove default_triple requirement from tests that specify the triple (authored by Jake-Egan). · Explain Why
This revision was automatically updated to reflect the committed changes.
Jake-Egan added a commit: rG158ac4a62765: [LTO] Remove default_triple requirement from tests that specify the triple.

Revision Contents

PathSize
llvm/
test/
LTO/
X86/
2 lines
1 line

Diff 392738

llvm/test/LTO/X86/bcsection.ll

Show All 10 Lines
; RUN: llvm-lto -exported-symbol=main -exported-symbol=_main -o %t/bcsection.elf.o %t/bcsection.elf.bco ; RUN: llvm-lto -exported-symbol=main -exported-symbol=_main -o %t/bcsection.elf.o %t/bcsection.elf.bco
; RUN: llvm-nm %t/bcsection.elf.o | FileCheck %s ; RUN: llvm-nm %t/bcsection.elf.o | FileCheck %s
; RUN: llvm-mc -I=%t -filetype=obj -triple=x86_64-apple-darwin11 -o %t/bcsection.macho.bco %p/Inputs/bcsection.macho.s ; RUN: llvm-mc -I=%t -filetype=obj -triple=x86_64-apple-darwin11 -o %t/bcsection.macho.bco %p/Inputs/bcsection.macho.s
; RUN: llvm-nm %t/bcsection.macho.bco | FileCheck %s ; RUN: llvm-nm %t/bcsection.macho.bco | FileCheck %s
; RUN: llvm-lto -exported-symbol=main -exported-symbol=_main -o %t/bcsection.macho.o %t/bcsection.macho.bco ; RUN: llvm-lto -exported-symbol=main -exported-symbol=_main -o %t/bcsection.macho.o %t/bcsection.macho.bco
; RUN: llvm-nm %t/bcsection.macho.o | FileCheck %s ; RUN: llvm-nm %t/bcsection.macho.o | FileCheck %s
; REQUIRES: default_triple
target triple = "x86_64-unknown-linux-gnu" target triple = "x86_64-unknown-linux-gnu"
; CHECK: main ; CHECK: main
define i32 @main() { define i32 @main() {
ret i32 0 ret i32 0
} }

llvm/test/LTO/X86/current-section.ll

; RUN: llvm-as < %s >%t1 ; RUN: llvm-as < %s >%t1
; RUN: llvm-lto -o %t2 %t1 ; RUN: llvm-lto -o %t2 %t1
; REQUIRES: default_triple
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu" target triple = "x86_64-unknown-linux-gnu"
module asm ".align 4" module asm ".align 4"