Page MenuHomePhabricator

[LTO] Specify triple to address unknown binary format assertion
ClosedPublic

Authored by Jake-Egan on Nov 28 2021, 6:39 PM.

Details

Summary

On AIX, this test generates an XCOFF file and hits "unknown binary format" assertion in llvm-nm. This patch specifies the triple to mitigate this issue.

Diff Detail

Event Timeline

Jake-Egan created this revision.Nov 28 2021, 6:39 PM
Jake-Egan requested review of this revision.Nov 28 2021, 6:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2021, 6:39 PM
Jake-Egan edited the summary of this revision. (Show Details)Nov 28 2021, 6:46 PM
Jake-Egan added a reviewer: sfertile.
This revision is now accepted and ready to land.Nov 29 2021, 9:04 AM
This revision was landed with ongoing or failed builds.Dec 2 2021, 1:40 PM
This revision was automatically updated to reflect the committed changes.

Change looks okay. Specifically: The test is for bitcode embedded in Mach-O, so the change made probably doesn't affect the primary purpose of the test (since the Mach-O aspect was encoded in the first RUN line). In other words, adding the triple is not removing significant coverage for other targets.

Aside: I think the default_triple requirement can be removed?

Aside: I think the default_triple requirement can be removed?

Posted D115048 to address this.