Page MenuHomePhabricator

Move header ConstantFold.h into include directory
AcceptedPublic

Authored by sepavloff on Dec 3 2021, 2:31 AM.

Details

Summary

Functions in ConstantFold.h were declared as internal interface so this
header resided in lib directory. However the functions declared there
are useful in other places, in particular, in ConstantFolding.cpp. To
avoid code duplication, these functions are moved into include
directory, so the interface declared in ConstantFold.h is not internal
anymore.

This change only modes the include file, fixes references to it and
removes mentions about internal interface. No functional changes.

Diff Detail

Event Timeline

sepavloff created this revision.Dec 3 2021, 2:31 AM
sepavloff requested review of this revision.Dec 3 2021, 2:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2021, 2:31 AM
RKSimon added inline comments.Dec 3 2021, 2:41 AM
llvm/include/llvm/IR/ConstantFold.h
20

LLVM_IR_CONSTANTFOLD_H ?

sepavloff updated this revision to Diff 391596.Dec 3 2021, 3:01 AM

Fixed header guard

RKSimon accepted this revision.Dec 7 2021, 4:00 AM

LGTM

llvm/include/llvm/IR/ConstantFold.h
31

(style) Opcode

This revision is now accepted and ready to land.Dec 7 2021, 4:00 AM