This is an archive of the discontinued LLVM Phabricator instance.

Move header ConstantFold.h into include directory
AbandonedPublic

Authored by sepavloff on Dec 3 2021, 2:31 AM.

Details

Summary

Functions in ConstantFold.h were declared as internal interface so this
header resided in lib directory. However the functions declared there
are useful in other places, in particular, in ConstantFolding.cpp. To
avoid code duplication, these functions are moved into include
directory, so the interface declared in ConstantFold.h is not internal
anymore.

This change only modes the include file, fixes references to it and
removes mentions about internal interface. No functional changes.

Diff Detail

Event Timeline

sepavloff created this revision.Dec 3 2021, 2:31 AM
sepavloff requested review of this revision.Dec 3 2021, 2:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2021, 2:31 AM
RKSimon added inline comments.Dec 3 2021, 2:41 AM
llvm/include/llvm/IR/ConstantFold.h
20

LLVM_IR_CONSTANTFOLD_H ?

sepavloff updated this revision to Diff 391596.Dec 3 2021, 3:01 AM

Fixed header guard

RKSimon accepted this revision.Dec 7 2021, 4:00 AM

LGTM

llvm/include/llvm/IR/ConstantFold.h
31

(style) Opcode

This revision is now accepted and ready to land.Dec 7 2021, 4:00 AM

@sepavloff Are you still intending to commit this?

D110322 was remade and this change is not necessary for it anymore. But this change could be needed it we modify constant evaluation for constrained intrinsics by moving the evaluation into a separate pass.

Do you need these patch? If yes, I will commit it.

D110322 was remade and this change is not necessary for it anymore. But this change could be needed it we modify constant evaluation for constrained intrinsics by moving the evaluation into a separate pass.

Do you need these patch? If yes, I will commit it.

I was mainly triaging accepted-but-uncommited phabs in the run up to the 14.x branch, but I see no harm in committing this if you see a future use, or maybe abandon it (no pressure though!) to avoid bitrot?

D110322 was remade and this change is not necessary for it anymore. But this change could be needed it we modify constant evaluation for constrained intrinsics by moving the evaluation into a separate pass.

Do you need these patch? If yes, I will commit it.

I was mainly triaging accepted-but-uncommited phabs in the run up to the 14.x branch, but I see no harm in committing this if you see a future use, or maybe abandon it (no pressure though!) to avoid bitrot?

I created D118319, depending on review feedback destiny of this patch will be resolved in a couple of days.

sepavloff abandoned this revision.Jan 31 2022, 8:23 AM

Neither D110322 nor D118426 now do not depend on this patch. Although this patch can be useful in future, now it is not needed. To keep records clean the patch is abandoned.

llvm/include/llvm/IR/ConstantFold.h