This is an archive of the discontinued LLVM Phabricator instance.

Differential D114683

[LTO] Specify triple to address unknown binary format assertion
ClosedPublic

Authored by Jake-Egan on Nov 28 2021, 6:39 PM.

Details

Reviewers
sfertile
steven_wu
Commits
rG1e328b06c152: [LTO] Specify triple to address unknown binary format assertion
Summary

On AIX, this test generates an XCOFF file and hits "unknown binary format" assertion in llvm-nm. This patch specifies the triple to mitigate this issue.

Diff Detail

Unit TestsFailed

TimeTest
11,400 msx64 debian > libFuzzer.libFuzzer::entropic-scale-per-exec-time.test

Event Timeline

Jake-Egan created this revision.Nov 28 2021, 6:39 PM
Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. · View Herald TranscriptNov 28 2021, 6:39 PM
Jake-Egan requested review of this revision.Nov 28 2021, 6:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2021, 6:39 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Jake-Egan edited the summary of this revision. (Show Details)Nov 28 2021, 6:46 PM
Jake-Egan added a reviewer: sfertile.
Harbormaster completed remote builds in B136360: Diff 390235.Nov 28 2021, 7:19 PM
steven_wu accepted this revision.Nov 29 2021, 9:04 AM

LGTM.

This revision is now accepted and ready to land.Nov 29 2021, 9:04 AM
This revision was landed with ongoing or failed builds.Dec 2 2021, 1:40 PM
Closed by commit rG1e328b06c152: [LTO] Specify triple to address unknown binary format assertion (authored by Jake-Egan). · Explain Why
This revision was automatically updated to reflect the committed changes.
Jake-Egan added a commit: rG1e328b06c152: [LTO] Specify triple to address unknown binary format assertion.
hubert.reinterpretcast added a subscriber: hubert.reinterpretcast.Dec 2 2021, 5:10 PM

Change looks okay. Specifically: The test is for bitcode embedded in Mach-O, so the change made probably doesn't affect the primary purpose of the test (since the Mach-O aspect was encoded in the first RUN line). In other words, adding the triple is not removing significant coverage for other targets.

Aside: I think the default_triple requirement can be removed?

Jake-Egan added a comment.Dec 3 2021, 8:34 AM

Aside: I think the default_triple requirement can be removed?

Posted D115048 to address this.

Revision Contents

PathSize
llvm/
test/
LTO/
X86/
2 lines

Diff 390235

llvm/test/LTO/X86/bcsection.ll

Show All 12 Lines
; RUN: llvm-mc -I=%t -filetype=obj -triple=x86_64-apple-darwin11 -o %t/bcsection.macho.bco %p/Inputs/bcsection.macho.s ; RUN: llvm-mc -I=%t -filetype=obj -triple=x86_64-apple-darwin11 -o %t/bcsection.macho.bco %p/Inputs/bcsection.macho.s
; RUN: llvm-nm %t/bcsection.macho.bco | FileCheck %s ; RUN: llvm-nm %t/bcsection.macho.bco | FileCheck %s
; RUN: llvm-lto -exported-symbol=main -exported-symbol=_main -o %t/bcsection.macho.o %t/bcsection.macho.bco ; RUN: llvm-lto -exported-symbol=main -exported-symbol=_main -o %t/bcsection.macho.o %t/bcsection.macho.bco
; RUN: llvm-nm %t/bcsection.macho.o | FileCheck %s ; RUN: llvm-nm %t/bcsection.macho.o | FileCheck %s
; REQUIRES: default_triple ; REQUIRES: default_triple
target triple = "x86_64-unknown-linux-gnu"
; CHECK: main ; CHECK: main
define i32 @main() { define i32 @main() {
ret i32 0 ret i32 0
} }