Page MenuHomePhabricator

[clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new
Needs ReviewPublic

Authored by balazske on Thu, Nov 25, 8:37 AM.

Details

Diff Detail

Event Timeline

balazske created this revision.Thu, Nov 25, 8:37 AM
balazske requested review of this revision.Thu, Nov 25, 8:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Nov 25, 8:37 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Eugene.Zelenko added inline comments.Thu, Nov 25, 9:04 AM
clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst
65

Two excessive newlines.

whisperity added inline comments.
clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst
55

What does

exception types or exceptions

mean?

55

by the code is either superfluous or misleading. Did you mean that the exception should be caught and handled in the same scope where the allocation took place?

60

Is that the warning message the check prints?

60–61
69
whisperity retitled this revision from [clang-tidy] Improve documentation of bugprone-unhandled-exception-at-new [NFC] to [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new.Fri, Nov 26, 4:28 AM
balazske updated this revision to Diff 390048.Fri, Nov 26, 7:06 AM

Apply of review comments.

balazske marked 5 inline comments as done.Fri, Nov 26, 7:09 AM
balazske added inline comments.
clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst
55

Now it is probably better. "Other exception" is any thrown exception of other class than the mentioned ones.

60

Warning text is changed to the exact checker's message.