This is an archive of the discontinued LLVM Phabricator instance.

[InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment
ClosedPublic

Authored by ellis on Nov 19 2021, 10:59 AM.

Details

Summary

The llvm.instrprof.increment intrinsic uses i32 for the index. We should use this same type for the index into the GEP instructions.

Diff Detail

Event Timeline

ellis created this revision.Nov 19 2021, 10:59 AM
ellis updated this revision to Diff 388564.Nov 19 2021, 11:01 AM

Run clang-format.

ellis edited the summary of this revision. (Show Details)Nov 19 2021, 11:08 AM
ellis added a reviewer: MaskRay.
ellis retitled this revision from [InstrProf] Use i32 for GEP index to [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment.
ellis published this revision for review.Nov 19 2021, 11:11 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 19 2021, 11:11 AM
MaskRay accepted this revision.EditedNov 19 2021, 2:40 PM

Add names to pgo registers for clarity.

This may increase memory usage, especially for large LTO applications. Unless this is very helpful I might omit it.

This revision is now accepted and ready to land.Nov 19 2021, 2:40 PM
ellis added a comment.Nov 19 2021, 2:45 PM

Add names to pgo registers for clarity.

This may increase memory usage, especially for large LTO applications. Unless this is very helpful I might omit it.

I'll omit it. Thanks for the quick review!

ellis updated this revision to Diff 388652.Nov 19 2021, 3:40 PM

Remove register names

ellis edited the summary of this revision. (Show Details)Nov 19 2021, 3:40 PM
This revision was landed with ongoing or failed builds.Nov 19 2021, 3:45 PM
This revision was automatically updated to reflect the committed changes.