This is an archive of the discontinued LLVM Phabricator instance.

Differential D114100

[NFC][clang-tools-extra] Inclusive language: replace master with main
ClosedPublic

Authored by quinnp on Nov 17 2021, 9:09 AM.

Details

Reviewers
sammccall
jtsoftware
ZarkoCA
nemanjai
Commits
rGc3dc6b081da6: [NFC][clang-tools-extra] Inclusive language: replace master with main
Summary

[NFC] As part of using inclusive language within the llvm project, this patch
replaces master with main in SubModule2.h.

Diff Detail

Event Timeline

quinnp created this revision.Nov 17 2021, 9:09 AM
Herald added subscribers: usaxena95, kadircet, arphaman. · View Herald TranscriptNov 17 2021, 9:09 AM
quinnp requested review of this revision.Nov 17 2021, 9:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 17 2021, 9:09 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
quinnp added reviewers: sammccall, jtsoftware, ZarkoCA, nemanjai.Nov 17 2021, 9:10 AM
Harbormaster completed remote builds in B134754: Diff 387961.Nov 17 2021, 9:28 AM
sammccall added inline comments.Nov 17 2021, 10:23 AM
clang-tools-extra/clangd/Protocol.h
141 ↗(On Diff #387961)

This is quoting https://microsoft.github.io/language-server-protocol/specification.
I think they accept PRs though.

quinnp marked an inline comment as done.Nov 17 2021, 10:38 AM
quinnp added inline comments.
clang-tools-extra/clangd/Protocol.h
141 ↗(On Diff #387961)

Thanks @sammccall, I'll remove this change from the patch.

quinnp updated this revision to Diff 387990.Nov 17 2021, 10:40 AM
quinnp marked an inline comment as done.

Addressing review comments. Reverting change to Protocol.h.

quinnp edited the summary of this revision. (Show Details)Nov 17 2021, 10:41 AM
Harbormaster completed remote builds in B134771: Diff 387990.Nov 17 2021, 10:57 AM
quinnp added a comment.Nov 24 2021, 10:28 AM

@sammccall could you take a look at the other changes when you have time? Thanks!

sammccall accepted this revision.Nov 25 2021, 7:46 AM

Sorry, LG!
(I'm not very familiar with clang-modularize, but this seems to be the only place the term is used)

This revision is now accepted and ready to land.Nov 25 2021, 7:46 AM
Closed by commit rGc3dc6b081da6: [NFC][clang-tools-extra] Inclusive language: replace master with main (authored by quinnp). · Explain WhyNov 25 2021, 9:01 AM
This revision was automatically updated to reflect the committed changes.
quinnp added a commit: rGc3dc6b081da6: [NFC][clang-tools-extra] Inclusive language: replace master with main.

Revision Contents

PathSize
clang-tools-extra/
test/
modularize/
2 lines

Diff 389818

clang-tools-extra/test/modularize/SubModule2.h

// SubModule2.h - Master header with same name as directory. // SubModule2.h - Main header with same name as directory.
#include "SubModule2/Header3.h" #include "SubModule2/Header3.h"
#include "SubModule2/Header4.h" #include "SubModule2/Header4.h"