Page MenuHomePhabricator

[NFC][flang] Inclusive language: remove instances of master
ClosedPublic

Authored by quinnp on Mon, Nov 15, 10:53 AM.

Details

Summary

[NFC] As part of using inclusive language within the llvm project, this patch:

  • replaces master with main in C++style.md to match the renaming of the master

branch,

  • removes master from FortranIR.md where it is superfluous,
  • renames a logical variable in pre-fir-tree04.f90 containing master.

Diff Detail

Event Timeline

quinnp created this revision.Mon, Nov 15, 10:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Nov 15, 10:53 AM
quinnp requested review of this revision.Mon, Nov 15, 10:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Nov 15, 10:53 AM
schweitz added inline comments.Tue, Nov 16, 8:04 AM
flang/test/Lower/pre-fir-tree04.f90
13

Can you leave a LOGICAL variable declaration and just give the variable a new name instead? Could be a property like is_square or something.

quinnp updated this revision to Diff 387817.Tue, Nov 16, 9:16 PM
quinnp marked an inline comment as done.

Address review comments.

This comment was removed by quinnp.
flang/test/Lower/pre-fir-tree04.f90
13

Sure @schweitz, thanks for the feedback! I renamed the variable to is_square.

quinnp edited the summary of this revision. (Show Details)Tue, Nov 16, 9:19 PM
quinnp edited the summary of this revision. (Show Details)

@schweitz could you take a look at the new changes when you have time? Thanks!

ZarkoCA accepted this revision.Thu, Nov 25, 1:04 PM
This revision is now accepted and ready to land.Thu, Nov 25, 1:04 PM