Paths

Table of Contentst

parse method (NFC)
ClosedPublic
Actions

Authored by mehdi_amini on Nov 10 2021, 6:51 PM.

Details

Reviewers

rriddle
aartbik
ftynse
nicolasvasilache

Commits

rGf97e72aaca4a: Use base class AsmParser/AsmPrinter in Types and Attribute print/parse method…

Summary

This decouples the printing/parsing from the "context" in which the parsing occurs.
This'll allow to invoke these methods directly using an OpAsmParser/OpAsmPrinter.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mehdi_amini created this revision.Nov 10 2021, 6:51 PM

Herald added a reviewer: aartbik. · View Herald TranscriptNov 10 2021, 6:51 PM

Herald added a reviewer: ftynse. · View Herald Transcript

Herald added a reviewer: aartbik. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan and 18 others. · View Herald Transcript

mehdi_amini requested review of this revision.Nov 10 2021, 6:51 PM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptNov 10 2021, 6:51 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

possible typo in description: I'll allow

This revision is now accepted and ready to land.Nov 10 2021, 6:55 PM

Harbormaster completed remote builds in B133641: Diff 386399.Nov 10 2021, 7:07 PM

mehdi_amini edited the summary of this revision. (Show Details)Nov 10 2021, 7:58 PM

This revision was landed with ongoing or failed builds.Nov 10 2021, 10:26 PM

Closed by commit rGf97e72aaca4a: Use base class AsmParser/AsmPrinter in Types and Attribute print/parse method… (authored by mehdi_amini). · Explain Why

This revision was automatically updated to reflect the committed changes.

mehdi_amini added a commit: rGf97e72aaca4a: Use base class AsmParser/AsmPrinter in Types and Attribute print/parse method….

LGTM sparse

Revision Contents
Changeset List

Path

Size

flang/

lib/

Optimizer/

Dialect/

FIRType.cpp

86 lines

mlir/

include/

mlir/

Dialect/

DLTI/

DLTI.h

8 lines

LLVMIR/

LLVMTypes.h

6 lines

Vector/

VectorOps.h

4 lines

IR/

DialectImplementation.h

8 lines

lib/

Dialect/

Async/

IR/

Async.cpp

4 lines

DLTI/

DLTI.cpp

8 lines

EmitC/

IR/

EmitC.cpp

8 lines

LLVMIR/

IR/

LLVMDialect.cpp

12 lines

LLVMTypeSyntax.cpp

37 lines

PDL/

IR/

PDLTypes.cpp

6 lines

SparseTensor/

IR/

SparseTensorDialect.cpp

4 lines

Vector/

VectorOps.cpp

6 lines

test/

lib/

Dialect/

Test/

TestAttributes.cpp

26 lines

TestTypes.h

6 lines

TestTypes.cpp

16 lines

mlir-tblgen/

attr-or-type-format.td

24 lines

attrdefs.td

10 lines

typedefs.td

14 lines

tools/

mlir-tblgen/

AttrOrTypeDefGen.cpp

14 lines

AttrOrTypeFormatGen.cpp

6 lines

Diff 386423

View Options

flang/lib/Optimizer/Dialect/FIRType.cpp

View Options

mlir/include/mlir/Dialect/DLTI/DLTI.h

View Options

mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.h

View Options

mlir/include/mlir/Dialect/Vector/VectorOps.h

View Options

mlir/include/mlir/IR/DialectImplementation.h

View Options

mlir/lib/Dialect/Async/IR/Async.cpp

View Options

mlir/lib/Dialect/DLTI/DLTI.cpp

View Options

mlir/lib/Dialect/EmitC/IR/EmitC.cpp

View Options

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

View Options

mlir/lib/Dialect/LLVMIR/IR/LLVMTypeSyntax.cpp

View Options

mlir/lib/Dialect/PDL/IR/PDLTypes.cpp

View Options

mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

View Options

mlir/lib/Dialect/Vector/VectorOps.cpp

View Options

mlir/test/lib/Dialect/Test/TestAttributes.cpp

View Options

mlir/test/lib/Dialect/Test/TestTypes.h

View Options

mlir/test/lib/Dialect/Test/TestTypes.cpp

View Options

mlir/test/mlir-tblgen/attr-or-type-format.td

View Options

mlir/test/mlir-tblgen/attrdefs.td

View Options

mlir/test/mlir-tblgen/typedefs.td

View Options

mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp

View Options

mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp

Use base class AsmParser/AsmPrinter in Types and Attribute print/parse method (NFC)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 386423

flang/lib/Optimizer/Dialect/FIRType.cpp

mlir/include/mlir/Dialect/DLTI/DLTI.h

mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.h

mlir/include/mlir/Dialect/Vector/VectorOps.h

mlir/include/mlir/IR/DialectImplementation.h

mlir/lib/Dialect/Async/IR/Async.cpp

mlir/lib/Dialect/DLTI/DLTI.cpp

mlir/lib/Dialect/EmitC/IR/EmitC.cpp

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

mlir/lib/Dialect/LLVMIR/IR/LLVMTypeSyntax.cpp

mlir/lib/Dialect/PDL/IR/PDLTypes.cpp

mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

mlir/lib/Dialect/Vector/VectorOps.cpp

mlir/test/lib/Dialect/Test/TestAttributes.cpp

mlir/test/lib/Dialect/Test/TestTypes.h

mlir/test/lib/Dialect/Test/TestTypes.cpp

mlir/test/mlir-tblgen/attr-or-type-format.td

mlir/test/mlir-tblgen/attrdefs.td

mlir/test/mlir-tblgen/typedefs.td

mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp

mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp

Use base class AsmParser/AsmPrinter in Types and Attribute print/parse method (NFC)
ClosedPublic
Actions

Revision Contents
Changeset List