Page MenuHomePhabricator

Use base class AsmParser/AsmPrinter in Types and Attribute print/parse method (NFC)

Authored by mehdi_amini on Nov 10 2021, 6:51 PM.



This decouples the printing/parsing from the "context" in which the parsing occurs.
This'll allow to invoke these methods directly using an OpAsmParser/OpAsmPrinter.

Diff Detail

Event Timeline

mehdi_amini created this revision.Nov 10 2021, 6:51 PM
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
mehdi_amini requested review of this revision.Nov 10 2021, 6:51 PM
rriddle accepted this revision.EditedNov 10 2021, 6:55 PM

possible typo in description: I'll allow

This revision is now accepted and ready to land.Nov 10 2021, 6:55 PM
mehdi_amini edited the summary of this revision. (Show Details)Nov 10 2021, 7:58 PM
This revision was landed with ongoing or failed builds.Nov 10 2021, 10:26 PM
This revision was automatically updated to reflect the committed changes.

LGTM sparse