This patch marks libunwind test case signal_frame.pass.cpp as UNSUPPORTED on AIX because the AIX assembler does not support CFI directives.
Details
Details
- Reviewers
compnerd steven_wu daltenty sfertile danielkiss MaskRay ldionne - Group Reviewers
Restricted Project - Commits
- rG11982eed2bc8: [libunwind][AIX] Mark signal_frame.pass.cpp UNSUPPORTED on AIX
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM.
libunwind/test/signal_frame.pass.cpp | ||
---|---|---|
18 | I assume that you have checked that target=powerpc{{|64}}-ibm-aix work with both UNSUPPORTED and REQUIRES. |
Comment Actions
LGTM with suggestions.
libunwind/test/signal_frame.pass.cpp | ||
---|---|---|
18 | Yes it does -- it's just a normal Lit feature. Please add a comment explaining: // The AIX assembler does not support CFI directives, which // are necessary to run this test. // UNSUPPORTED: target=powerpc{{(64)?}}-ibm-aix I also suggest using (64)? instead of |64 for the regex. It seems more idiomatic to me. |
Comment Actions
Thanks for reviewing this patch, @danielkiss, @MaskRay, @ldionne! Yes, target=powerpc-ibm-aix (32-bit) and target=powerpc64-ibm-aix (64-bit) are LIT features. Updated the patch as suggested. Thanks, @ldionne!
I assume that you have checked that target=powerpc{{|64}}-ibm-aix work with both UNSUPPORTED and REQUIRES.