This is an archive of the discontinued LLVM Phabricator instance.

[libunwind][AIX] Mark signal_frame.pass.cpp UNSUPPORTED on AIX
ClosedPublic

Authored by xingxue on Nov 10 2021, 12:55 PM.

Details

Summary

This patch marks libunwind test case signal_frame.pass.cpp as UNSUPPORTED on AIX because the AIX assembler does not support CFI directives.

Diff Detail

Event Timeline

xingxue created this revision.Nov 10 2021, 12:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2021, 12:55 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
xingxue requested review of this revision.Nov 10 2021, 12:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2021, 12:55 PM
danielkiss accepted this revision.Nov 11 2021, 1:06 AM
MaskRay accepted this revision.Nov 17 2021, 6:04 PM
MaskRay added a subscriber: MaskRay.

LGTM.

libunwind/test/signal_frame.pass.cpp
18

I assume that you have checked that target=powerpc{{|64}}-ibm-aix work with both UNSUPPORTED and REQUIRES.

This revision is now accepted and ready to land.Nov 17 2021, 6:04 PM
ldionne accepted this revision.Nov 18 2021, 5:40 AM
ldionne added a subscriber: ldionne.

LGTM with suggestions.

libunwind/test/signal_frame.pass.cpp
18

Yes it does -- it's just a normal Lit feature.

Please add a comment explaining:

// The AIX assembler does not support CFI directives, which
// are necessary to run this test.
// UNSUPPORTED: target=powerpc{{(64)?}}-ibm-aix

I also suggest using (64)? instead of |64 for the regex. It seems more idiomatic to me.

This revision was landed with ongoing or failed builds.Nov 18 2021, 7:30 AM
This revision was automatically updated to reflect the committed changes.

Thanks for reviewing this patch, @danielkiss, @MaskRay, @ldionne! Yes, target=powerpc-ibm-aix (32-bit) and target=powerpc64-ibm-aix (64-bit) are LIT features. Updated the patch as suggested. Thanks, @ldionne!