Page MenuHomePhabricator

[mlir] support recursive type conversion of named LLVM structs
ClosedPublic

Authored by ftynse on Nov 10 2021, 9:55 AM.

Details

Summary

A previous commit added support for converting elemental types contained in
LLVM dialect types in case they were not compatible with the LLVM dialect. It
was missing support for named structs as they could be recursive, which was not
supported by the conversion infra. Now that it is, add support for converting
such named structs.

Depends On D113579

Diff Detail

Event Timeline

ftynse created this revision.Nov 10 2021, 9:55 AM
ftynse requested review of this revision.Nov 10 2021, 9:55 AM
wsmoses accepted this revision.Dec 1 2021, 10:21 AM
This revision is now accepted and ready to land.Dec 1 2021, 10:21 AM
kiranchandramohan added inline comments.
mlir/lib/Conversion/LLVMCommon/TypeConverter.cpp
67

Was the counter increment missed here?