Page MenuHomePhabricator
Differential D113546

[linalg][mlir] Replace getSmallestBoundingIndex in padding (NFC).
ClosedPublic
Actions

Authored by gysit on Nov 10 2021, 12:11 AM.

Details

Reviewers
nicolasvasilache
Commits
rGea53a6938b12: [linalg][mlir] Replace getSmallestBoundingIndex in padding (NFC).
Summary

Replace the getSmallestBoundingIndex method used in padding by getConstantUpperBoundForIndex that uses flat affine constraints to compute a constant upper bound.

Depends On D113398

Diff Detail

Event Timeline

gysit created this revision.Nov 10 2021, 12:11 AM
Herald added subscribers: Groverkss, wenzhicui, wrengr and 22 others. · View Herald TranscriptNov 10 2021, 12:11 AM
gysit requested review of this revision.Nov 10 2021, 12:11 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptNov 10 2021, 12:11 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
gysit added a child revision: D113547: [mlir][linalg] Use getUpperBoundForIndex in hoisting (NFC)..Nov 10 2021, 12:12 AM
gysit added a child revision: D113548: [linalg][mlir] Replace getSmallestBoundingIndex in promotion (NFC)..Nov 10 2021, 12:22 AM
Harbormaster completed remote builds in B133425: Diff 386072.Nov 10 2021, 12:25 AM
nicolasvasilache accepted this revision.Nov 10 2021, 4:36 AM
nicolasvasilache added inline comments.
mlir/lib/Dialect/Linalg/Utils/Utils.cpp
300

I can imagine that in a world where simplifications are not done you may have multiple constants; return the smallest ?

This revision is now accepted and ready to land.Nov 10 2021, 4:36 AM
gysit updated this revision to Diff 386147.Nov 10 2021, 6:57 AM

Address comment.

gysit marked an inline comment as done.Nov 10 2021, 6:58 AM
gysit added inline comments.
mlir/lib/Dialect/Linalg/Utils/Utils.cpp
300

Yes makes sense!

Harbormaster completed remote builds in B133472: Diff 386147.Nov 10 2021, 7:08 AM
Closed by commit rGea53a6938b12: [linalg][mlir] Replace getSmallestBoundingIndex in padding (NFC). (authored by gysit). · Explain WhyNov 10 2021, 7:16 AM
This revision was automatically updated to reflect the committed changes.
gysit marked an inline comment as done.
gysit added a commit: rGea53a6938b12: [linalg][mlir] Replace getSmallestBoundingIndex in padding (NFC)..

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Linalg/
Utils/
34 lines
lib/
Dialect/
Linalg/
Transforms/
18 lines
Utils/
106 lines

Diff 386147

View Options

mlir/include/mlir/Dialect/Linalg/Utils/Utils.h

Loading...
View Options

mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp

Loading...
View Options

mlir/lib/Dialect/Linalg/Utils/Utils.cpp

Loading...