Page MenuHomePhabricator

[linalg][mlir] Replace getSmallestBoundingIndex in padding (NFC).
ClosedPublic

Authored by gysit on Wed, Nov 10, 12:11 AM.

Details

Summary

Replace the getSmallestBoundingIndex method used in padding by getConstantUpperBoundForIndex that uses flat affine constraints to compute a constant upper bound.

Depends On D113398

Diff Detail

Event Timeline

gysit created this revision.Wed, Nov 10, 12:11 AM
gysit requested review of this revision.Wed, Nov 10, 12:11 AM
nicolasvasilache accepted this revision.Wed, Nov 10, 4:36 AM
nicolasvasilache added inline comments.
mlir/lib/Dialect/Linalg/Utils/Utils.cpp
300

I can imagine that in a world where simplifications are not done you may have multiple constants; return the smallest ?

This revision is now accepted and ready to land.Wed, Nov 10, 4:36 AM
gysit updated this revision to Diff 386147.Wed, Nov 10, 6:57 AM

Address comment.

gysit marked an inline comment as done.Wed, Nov 10, 6:58 AM
gysit added inline comments.
mlir/lib/Dialect/Linalg/Utils/Utils.cpp
300

Yes makes sense!

This revision was automatically updated to reflect the committed changes.
gysit marked an inline comment as done.