This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][CI][AIX] Switch to LLVM_ENABLE_RUNTIMES
ClosedPublic

Authored by daltenty on Nov 8 2021, 7:53 AM.

Details

Reviewers
ldionne
hubert.reinterpretcast
sfertile
xingxue
Group Reviewers
Restricted Project
Restricted Project
Commits
rG2b416b46479d: [libcxx][CI][AIX] Switch to LLVM_ENABLE_RUNTIMES
Summary

and to the new runtimes top level CMakeLists.txt since the old path is now deprecated. This requires a slight adjustment of the libcxxabi CMake, since there are required macro definitions we previously got via the llvm/CMakeList.txt path.

Diff Detail

Event Timeline

daltenty created this revision.Nov 8 2021, 7:53 AM
daltenty requested review of this revision.Nov 8 2021, 7:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2021, 7:53 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
daltenty updated this revision to Diff 385500.Nov 8 2021, 7:54 AM
  • Remove duplicate option
daltenty planned changes to this revision.Nov 8 2021, 1:17 PM
daltenty updated this revision to Diff 385786.Nov 9 2021, 5:29 AM
  • [libcxxabi] Avoid the VMX malloc to vec_malloc mapping
  • Un-XFAIL test fixed by the more narrowly application of XOPEN_SOURCE macros
Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2021, 5:29 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: mgorny. · View Herald Transcript
daltenty edited the summary of this revision. (Show Details)Nov 9 2021, 5:32 AM
daltenty edited the summary of this revision. (Show Details)
daltenty edited the summary of this revision. (Show Details)
ldionne accepted this revision.Nov 9 2021, 7:13 AM
ldionne added inline comments.
libcxx/utils/ci/run-buildbot
116–120

Can we get rid of generate-cmake-aix entirely since it is only used in one place?

libcxxabi/CMakeLists.txt
522–526

Is this a different workaround for https://reviews.llvm.org/D112168?

524
This revision is now accepted and ready to land.Nov 9 2021, 7:13 AM
daltenty added inline comments.Nov 9 2021, 9:28 AM
libcxx/utils/ci/run-buildbot
116–120

I think that makes sense, since these defines should be just last option wins, I'll move this in to the AIX block itself.

libcxxabi/CMakeLists.txt
522–526

Precisely, the XOPEN_SOURCE macro suppresses the malloc to vec_malloc mapping in the system header, so we don't see the problematic redefinition and corresponding alignment change (at least in libcxxabi where it causes the most disruption to existing applications).

daltenty updated this revision to Diff 385859.Nov 9 2021, 9:46 AM
  • Move DLLVM_ENABLE_RUNTIMES into aix block
This revision was automatically updated to reflect the committed changes.