Page MenuHomePhabricator

[llvm] [Debuginfo] Add cpp-httplib optional dependency.
AcceptedPublic

Authored by noajshu on Nov 4 2021, 3:13 PM.

Details

Reviewers
phosek
Summary

Adds optional dependency on cpp-httplib, a lightweight header-only HTTP server.

Diff Detail

Unit TestsFailed

TimeTest
1,550 msx64 debian > SanitizerCommon-asan-x86_64-Linux.Linux::decorate_proc_maps.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -gline-tables-only -fsanitize=address -m64 -funwind-tables -ldl -g /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Linux/decorate_proc_maps.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/sanitizer_common/asan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp.tmp
340 msx64 debian > SanitizerCommon-lsan-x86_64-Linux.Linux::decorate_proc_maps.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -gline-tables-only -fsanitize=leak -m64 -funwind-tables -ldl -g /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Linux/decorate_proc_maps.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/sanitizer_common/lsan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp.tmp
490 msx64 debian > SanitizerCommon-msan-x86_64-Linux.Linux::decorate_proc_maps.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -gline-tables-only -fsanitize=memory -m64 -funwind-tables -ldl -g /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Linux/decorate_proc_maps.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/sanitizer_common/msan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp.tmp
640 msx64 debian > SanitizerCommon-tsan-x86_64-Linux.Linux::decorate_proc_maps.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -gline-tables-only -fsanitize=thread -m64 -funwind-tables -ldl -g /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Linux/decorate_proc_maps.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/sanitizer_common/tsan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp.tmp

Event Timeline

noajshu created this revision.Nov 4 2021, 3:13 PM
noajshu requested review of this revision.Nov 4 2021, 3:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2021, 3:13 PM
noajshu updated this revision to Diff 388805.Nov 21 2021, 11:45 PM

Clean up old cmake comments.

noajshu updated this revision to Diff 389071.Nov 22 2021, 5:11 PM

Add #cmakedefine for LLVM_ENABLE_CPP_HTTPLIB

phosek added inline comments.Nov 22 2021, 10:53 PM
llvm/CMakeLists.txt
412

I'd probably just call it LLVM_ENABLE_HTTPLIB, you already use HTTPLIB elsewhere (for example HAVE_HTTPLIB_HEADER).

llvm/cmake/config-ix.cmake
195–197

Why do we need to check all three?

noajshu updated this revision to Diff 389345.Nov 23 2021, 3:56 PM

Change LLVM_ENABLE_CPP_HTTPLIB -> LLVM_ENABLE_HTTPLIB and remove redundant use of check_cxx_symbol_exists.

noajshu marked 2 inline comments as done.Nov 23 2021, 3:57 PM
noajshu added inline comments.
llvm/cmake/config-ix.cmake
195–197

Good point, the additional checks are redundant. I've removed them.

phosek accepted this revision.Nov 23 2021, 6:57 PM

LGTM

This revision is now accepted and ready to land.Nov 23 2021, 6:57 PM
noajshu updated this revision to Diff 393696.Dec 11 2021, 2:12 PM
noajshu marked an inline comment as done.

Set default of LLVM_ENABLE_HTTPLIB to OFF

noajshu updated this revision to Diff 394650.Dec 15 2021, 1:24 PM

Add back missing include(CheckCXXSymbolExists)

noajshu updated this revision to Diff 400689.Mon, Jan 17, 6:43 PM

Rebase against main.