[mlir] Change ABI breaking use of NDEBUG to LLVM_ENABLE_ABI_BREAKING_CHECKS in DebugActions.h

[zero9178]

Summary

A quick grep for NDEBUG in MLIR revealed a use in DebugActions.h that breaks ABI. This patch changes the use of NDEBUG to LLVM_ENABLE_ABI_BREAKING_CHECKS which has the advantage of being independent of whether clients build their own app in debug or release as it is purely dependant on how MLIR itself was built.

Same case has previously been discussed for a different piece of code here: https://reviews.llvm.org/D107227

[mehdi_amini]

Thanks!

[lattner]

nice thanks

mlir/include/mlir/Support/DebugAction.h

public:
     static bool classof(const DebugActionManager::HandlerBase *handler) {
       return handler->getHandlerID() == TypeID::get<GenericHandler>();
     }
   };
 
   /// Register the given action handler with the manager.
   void registerActionHandler(std::unique_ptr<HandlerBase> handler) {
     // The manager is always disabled if built without debug.
-#ifndef NDEBUG
+#if LLVM_ENABLE_ABI_BREAKING_CHECKS
     actionHandlers.emplace_back(std::move(handler));
 #endif
   }
   template <typename T>
   void registerActionHandler() {
     registerActionHandler(std::make_unique<T>());
   }
 
   //===--------------------------------------------------------------------===//
   // Action Queries
   //===--------------------------------------------------------------------===//
 
   /// Returns true if the given action type should be executed, false otherwise.
   /// `Args` are a set of parameters used by handlers of `ActionType` to
   /// determine if the action should be executed.
   template <typename ActionType, typename... Args>
   bool shouldExecute(Args &&... args) {
     // The manager is always disabled if built without debug.
-#ifdef NDEBUG
+#if !LLVM_ENABLE_ABI_BREAKING_CHECKS
     return true;
 #else
     // Invoke the `shouldExecute` method on the provided handler.
     auto shouldExecuteFn = [&](auto *handler, auto &&... handlerParams) {
       return handler->shouldExecute(
           std::forward<decltype(handlerParams)>(handlerParams)...);
     };
     FailureOr<bool> result = dispatchToHandler<ActionType, bool>(
         shouldExecuteFn, std::forward<Args>(args)...);
 
     // If the action wasn't handled, execute the action by default.
     return succeeded(result) ? *result : true;
 #endif
   }
 
 private:
 // The manager is always disabled if built without debug.
-#ifndef NDEBUG
+#if LLVM_ENABLE_ABI_BREAKING_CHECKS
   //===--------------------------------------------------------------------===//
   // Query to Handler Dispatch
   //===--------------------------------------------------------------------===//
 
   /// Dispath a given callback on any handlers that are able to process queries
   /// on the given action type. This method returns failure if no handlers could
   /// process the action, or success(with a result) if a handler processed the
   /// action.