This is an archive of the discontinued LLVM Phabricator instance.

I think the C++ standard says this code should work, despite being stupid. But the const should be there anyway, because it doesn't modify anything.

Looks fine to me if it works. See also D112897.

This revision is now accepted and ready to land.Nov 2 2021, 3:24 AM

This revision was landed with ongoing or failed builds.Nov 2 2021, 6:28 AM

Closed by commit rGc5029023fb07: Fix building with GCC 12: (authored by marxin). · Explain Why

This revision was automatically updated to reflect the committed changes.

marxin added a commit: rGc5029023fb07: Fix building with GCC 12:.

N.B. the libstdc++ regression that caused this to fail has been fixed now.

Revision Contents

Path

Size

llvm/

lib/

Target/

AMDGPU/

SILoadStoreOptimizer.cpp

2 lines

Diff 383996

llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp

Show First 20 Lines • Show All 2,058 Lines • ▼ Show 20 Lines	if (MergeList.size() <= 1) {
// so this list can be discarded.		// so this list can be discarded.
I = MergeableInsts.erase(I);		I = MergeableInsts.erase(I);
continue;		continue;
}		}

// Sort the lists by offsets, this way mergeable instructions will be		// Sort the lists by offsets, this way mergeable instructions will be
// adjacent to each other in the list, which will make it easier to find		// adjacent to each other in the list, which will make it easier to find
// matches.		// matches.
MergeList.sort(		MergeList.sort(
		Lint: Pre-merge checks Inline Actions clang-format: please reformat the code - MergeList.sort( - [] (const CombineInfo &A, const CombineInfo &B) { - return A.Offset < B.Offset; - }); + MergeList.sort([](const CombineInfo &A, const CombineInfo &B) { + return A.Offset < B.Offset; + }); Lint: Pre-merge checks: clang-format: please reformat the code ``` - MergeList.sort( - [] (const CombineInfo…
[] (const CombineInfo &A, CombineInfo &B) {		[] (const CombineInfo &A, const CombineInfo &B) {
return A.Offset < B.Offset;		return A.Offset < B.Offset;
});		});
++I;		++I;
}		}

return std::make_pair(BlockI, Modified);		return std::make_pair(BlockI, Modified);
}		}

▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

Fix building with GCC 12ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 383996

llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp

Fix building with GCC 12
ClosedPublic