This is an archive of the discontinued LLVM Phabricator instance.

Fix building with GCC 12
ClosedPublic

Authored by marxin on Nov 2 2021, 1:37 AM.

Diff Detail

Event Timeline

marxin created this revision.Nov 2 2021, 1:37 AM
marxin requested review of this revision.Nov 2 2021, 1:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2021, 1:37 AM
jwakely added a subscriber: jwakely.Nov 2 2021, 2:48 AM

I think the C++ standard says this code should work, despite being stupid. But the const should be there anyway, because it doesn't modify anything.

foad accepted this revision.Nov 2 2021, 3:24 AM

Looks fine to me if it works. See also D112897.

This revision is now accepted and ready to land.Nov 2 2021, 3:24 AM
This revision was landed with ongoing or failed builds.Nov 2 2021, 6:28 AM
This revision was automatically updated to reflect the committed changes.

N.B. the libstdc++ regression that caused this to fail has been fixed now.