[NFC] Add size inference to to_vector

[GMNGeoffrey]

Summary

A default calculated size for SmallVector was added in
https://reviews.llvm.org/D92522 after discussion in
https://groups.google.com/g/llvm-dev/c/Z-VwNCTRGSg, but to_vector still
requires an explicit size. This patch adds the default size to to_vector
as well, so that this case doesn't unnecessarily force users to pick an
arbitrary size.

[GMNGeoffrey]

Please feel free to code golf this. I am a template metaprogramming noob.

[silvas]

This looks good to me. @rriddle @dexonsmith @dblaikie for thoughts.

Also, does this break any existing code? Or does overloading "just work" for the new defaulting case.

[GMNGeoffrey]

In D112968#3101480, @silvas wrote:

Also, does this break any existing code? Or does overloading "just work" for the new defaulting case.

I'm pretty sure it "just works", but am waiting on pre-merge checks.

I suppose I should actually add a usage of the new default case :-D I'll go do that.

[GMNGeoffrey]

• Add test for implicit to_vector size

[dblaikie]

Could do with a unit test in any case, but let's see about the implementation...

Yeah, I'm OK with it if it passes builds/bootstraps/bots/etc.

[dblaikie]

Thanks!

[mehdi_amini]

Nice! Thanks :)

llvm/include/llvm/ADT/SmallVector.h

public:
   }
 };
 
 template <typename T, unsigned N>
 inline size_t capacity_in_bytes(const SmallVector<T, N> &X) {
   return X.capacity_in_bytes();
 }
 
+template <typename RangeType>
+using ValueTypeFromRangeType =
+    typename std::remove_const<typename std::remove_reference<
+        decltype(*std::begin(std::declval<RangeType &>()))>::type>::type;
+
 /// Given a range of type R, iterate the entire range and return a
 /// SmallVector with elements of the vector.  This is useful, for example,
 /// when you want to iterate a range and then sort the results.
 template <unsigned Size, typename R>
-SmallVector<typename std::remove_const<typename std::remove_reference<
-                decltype(*std::begin(std::declval<R &>()))>::type>::type,
-            Size>
+SmallVector<ValueTypeFromRangeType<R>, Size> to_vector(R &&Range) {
+  return {std::begin(Range), std::end(Range)};
+}
+template <typename R>
+SmallVector<ValueTypeFromRangeType<R>,
+            CalculateSmallVectorDefaultInlinedElements<
+                ValueTypeFromRangeType<R>>::value>
 to_vector(R &&Range) {
   return {std::begin(Range), std::end(Range)};
 }
 
 } // end namespace llvm
 
 namespace std {
 

llvm/unittests/ADT/STLExtrasTest.cpp

 TEST(STLExtrasTest, ToVector) {
   std::vector<char> v = {'a', 'b', 'c'};
   auto Enumerated = to_vector<4>(enumerate(v));
   ASSERT_EQ(3u, Enumerated.size());
   for (size_t I = 0; I < v.size(); ++I) {
     EXPECT_EQ(I, Enumerated[I].index());
     EXPECT_EQ(v[I], Enumerated[I].value());
   }
+
+  auto EnumeratedImplicitSize = to_vector(enumerate(v));
+  ASSERT_EQ(3u, EnumeratedImplicitSize.size());
+  for (size_t I = 0; I < v.size(); ++I) {
+    EXPECT_EQ(I, EnumeratedImplicitSize[I].index());
+    EXPECT_EQ(v[I], EnumeratedImplicitSize[I].value());
+  }
 }
 
 TEST(STLExtrasTest, ConcatRange) {
   std::vector<int> Expected = {1, 2, 3, 4, 5, 6, 7, 8};
   std::vector<int> Test;
 
   std::vector<int> V1234 = {1, 2, 3, 4};
   std::list<int> L56 = {5, 6};