Page MenuHomePhabricator

[RISCV][VP] Mangle pointers in vp.load and vp.store tests
ClosedPublic

Authored by frasercrmck on Mon, Nov 1, 10:00 AM.

Details

Summary

Although this isn't required, it better matches the suggested syntax as
per the documentation work ongoing in D112930.

Diff Detail

Event Timeline

frasercrmck created this revision.Mon, Nov 1, 10:00 AM
frasercrmck requested review of this revision.Mon, Nov 1, 10:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Nov 1, 10:00 AM

This makes sense to me and matches what opt prints when it remangles the names.

LGTM

  • rebase on top of 'allones' tests pushed earlier

Thanks, Craig. Good point about opt. Is that official acceptance or would you like to wait for other comments?

craig.topper accepted this revision.Tue, Nov 2, 9:53 AM

I meant to officially accept it before.

This revision is now accepted and ready to land.Tue, Nov 2, 9:53 AM
This revision was landed with ongoing or failed builds.Tue, Nov 2, 9:55 AM
This revision was automatically updated to reflect the committed changes.