Page MenuHomePhabricator

[clangd] Record time spent in tidy checks
Needs ReviewPublic

Authored by kadircet on Oct 29 2021, 10:20 AM.

Details

Reviewers
sammccall

Diff Detail

Event Timeline

kadircet created this revision.Oct 29 2021, 10:20 AM
kadircet requested review of this revision.Oct 29 2021, 10:20 AM

My only concern with this is the overhead of the timing itself.
We look up the hash bucket, turn timers on/off...

If I'm understanding right we do this once per AST node per registered matcher. Are you able to see any performance difference with this tracing on vs off?

If there's a performance penalty but our goal is to gather enough statistics to be useful, we could consider only doing it every N reparses (or just with a certain probability).
But even then, if it's slow maybe we should only be running it in cases where we know we're sending the stats somewhere useful.

nridge added a subscriber: nridge.Oct 31 2021, 8:42 PM