Page MenuHomePhabricator

[clangd] Track performance of IncludeCleaner

Authored by kbobyrev on Oct 29 2021, 1:41 AM.

Diff Detail

Event Timeline

kbobyrev created this revision.Oct 29 2021, 1:41 AM
kbobyrev requested review of this revision.Oct 29 2021, 1:41 AM
kadircet added inline comments.Oct 29 2021, 2:26 AM

this doesn't look interesting on its own, as it doesn't perform much magic. maybe just drop?


i believe this is the function that deserves a trace the most, as it is alive throughout the whole interaction and will reflect full latency.

kbobyrev updated this revision to Diff 383278.Oct 29 2021, 2:49 AM
kbobyrev marked 2 inline comments as done.

Address review comments.

kadircet accepted this revision.Oct 29 2021, 3:49 AM

oops forgot to LGTM, thanks!

This revision is now accepted and ready to land.Oct 29 2021, 3:49 AM
This revision was automatically updated to reflect the committed changes.