Page MenuHomePhabricator

[clangd] Track performance of IncludeCleaner
ClosedPublic

Authored by kbobyrev on Fri, Oct 29, 1:41 AM.

Diff Detail

Event Timeline

kbobyrev created this revision.Fri, Oct 29, 1:41 AM
kbobyrev requested review of this revision.Fri, Oct 29, 1:41 AM
kadircet added inline comments.Fri, Oct 29, 2:26 AM
clang-tools-extra/clangd/IncludeCleaner.cpp
275

this doesn't look interesting on its own, as it doesn't perform much magic. maybe just drop?

283

i believe this is the function that deserves a trace the most, as it is alive throughout the whole interaction and will reflect full latency.

kbobyrev updated this revision to Diff 383278.Fri, Oct 29, 2:49 AM
kbobyrev marked 2 inline comments as done.

Address review comments.

kadircet accepted this revision.Fri, Oct 29, 3:49 AM

oops forgot to LGTM, thanks!

This revision is now accepted and ready to land.Fri, Oct 29, 3:49 AM
This revision was automatically updated to reflect the committed changes.