This is an archive of the discontinued LLVM Phabricator instance.

Differential D112574

[tosa][mlir] Add bailout to TosaMakeBroadcastable for unranked case
ClosedPublic

Authored by rsuderman on Oct 26 2021, 1:34 PM.

Details

Reviewers
sjarus
NatashaKnk
Commits
rGa35f54c3b469: [tosa][mlir] Add bailout to TosaMakeBroadcastable for unranked case
Summary

Dyn-cast should be checked and bailed out if the dyn_cast failed.

Diff Detail

Event Timeline

rsuderman created this revision.Oct 26 2021, 1:34 PM
Herald added a reviewer: sjarus. · View Herald TranscriptOct 26 2021, 1:34 PM
Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan and 22 others. · View Herald Transcript
rsuderman requested review of this revision.Oct 26 2021, 1:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2021, 1:34 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rsuderman added a reviewer: NatashaKnk.Oct 26 2021, 1:35 PM
sjarus accepted this revision.Oct 26 2021, 1:36 PM
This revision is now accepted and ready to land.Oct 26 2021, 1:36 PM
NatashaKnk accepted this revision.Oct 26 2021, 1:51 PM
Harbormaster completed remote builds in B130805: Diff 382450.Oct 26 2021, 1:54 PM
Closed by commit rGa35f54c3b469: [tosa][mlir] Add bailout to TosaMakeBroadcastable for unranked case (authored by rsuderman). · Explain WhyOct 26 2021, 3:39 PM
This revision was automatically updated to reflect the committed changes.
rsuderman added a commit: rGa35f54c3b469: [tosa][mlir] Add bailout to TosaMakeBroadcastable for unranked case.

Revision Contents

PathSize
mlir/
lib/
Dialect/
Tosa/
Transforms/
6 lines

Diff 382476

mlir/lib/Dialect/Tosa/Transforms/TosaMakeBroadcastable.cpp

Show First 20 Lines • Show All 179 Lines • ▼ Show 20 Linesstruct ConvertTosaOp : public OpRewritePattern<OpTy> {
LogicalResult matchAndRewrite(OpTy tosaBinaryOp, LogicalResult matchAndRewrite(OpTy tosaBinaryOp,
PatternRewriter &rewriter) const override { PatternRewriter &rewriter) const override {
Value input1 = tosaBinaryOp.input1(); Value input1 = tosaBinaryOp.input1();
Value input2 = tosaBinaryOp.input2(); Value input2 = tosaBinaryOp.input2();
Value output = tosaBinaryOp.getResult(); Value output = tosaBinaryOp.getResult();
auto outputType = output.getType().dyn_cast<RankedTensorType>(); auto outputType = output.getType().dyn_cast<RankedTensorType>();
if (!outputType)
return failure();
Value outInput1, outInput2; Value outInput1, outInput2;
if (reshapeLowerToHigher(rewriter, tosaBinaryOp.getLoc(), outputType, if (reshapeLowerToHigher(rewriter, tosaBinaryOp.getLoc(), outputType,
input1, input2, outInput1, outInput2) input1, input2, outInput1, outInput2)
.failed()) .failed())
return failure(); return failure();
rewriter.replaceOpWithNewOp<OpTy>(tosaBinaryOp, outputType, outInput1, rewriter.replaceOpWithNewOp<OpTy>(tosaBinaryOp, outputType, outInput1,
Show All 12 Linesstruct ConvertTosaOp<tosa::MulOp> : public OpRewritePattern<tosa::MulOp> {
LogicalResult matchAndRewrite(tosa::MulOp tosaBinaryOp, LogicalResult matchAndRewrite(tosa::MulOp tosaBinaryOp,
PatternRewriter &rewriter) const override { PatternRewriter &rewriter) const override {
Value input1 = tosaBinaryOp.input1(); Value input1 = tosaBinaryOp.input1();
Value input2 = tosaBinaryOp.input2(); Value input2 = tosaBinaryOp.input2();
int32_t shift = tosaBinaryOp.shift(); int32_t shift = tosaBinaryOp.shift();
Value output = tosaBinaryOp.getResult(); Value output = tosaBinaryOp.getResult();
auto outputType = output.getType().dyn_cast<RankedTensorType>(); auto outputType = output.getType().dyn_cast<RankedTensorType>();
if (!outputType)
return failure();
Value outInput1, outInput2; Value outInput1, outInput2;
if (reshapeLowerToHigher(rewriter, tosaBinaryOp.getLoc(), outputType, if (reshapeLowerToHigher(rewriter, tosaBinaryOp.getLoc(), outputType,
input1, input2, outInput1, outInput2) input1, input2, outInput1, outInput2)
.failed()) .failed())
return failure(); return failure();
rewriter.replaceOpWithNewOp<tosa::MulOp>(tosaBinaryOp, outputType, rewriter.replaceOpWithNewOp<tosa::MulOp>(tosaBinaryOp, outputType,
Show All 14 Linesstruct ConvertTosaOp<tosa::ArithmeticRightShiftOp>
LogicalResult matchAndRewrite(tosa::ArithmeticRightShiftOp tosaBinaryOp, LogicalResult matchAndRewrite(tosa::ArithmeticRightShiftOp tosaBinaryOp,
PatternRewriter &rewriter) const override { PatternRewriter &rewriter) const override {
Value input1 = tosaBinaryOp.input1(); Value input1 = tosaBinaryOp.input1();
Value input2 = tosaBinaryOp.input2(); Value input2 = tosaBinaryOp.input2();
int32_t round = tosaBinaryOp.round(); int32_t round = tosaBinaryOp.round();
Value output = tosaBinaryOp.getResult(); Value output = tosaBinaryOp.getResult();
auto outputType = output.getType().dyn_cast<RankedTensorType>(); auto outputType = output.getType().dyn_cast<RankedTensorType>();
if (!outputType)
return failure();
Value outInput1, outInput2; Value outInput1, outInput2;
if (reshapeLowerToHigher(rewriter, tosaBinaryOp.getLoc(), outputType, if (reshapeLowerToHigher(rewriter, tosaBinaryOp.getLoc(), outputType,
input1, input2, outInput1, outInput2) input1, input2, outInput1, outInput2)
.failed()) .failed())
return failure(); return failure();
rewriter.replaceOpWithNewOp<tosa::ArithmeticRightShiftOp>( rewriter.replaceOpWithNewOp<tosa::ArithmeticRightShiftOp>(
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines