msan: disble CHECK test on powerpc64

[dvyukov]

Summary

It seems that CHECK terminates the process with 0 status on powerpc64:
https://reviews.llvm.org/D112440#3084251
Disable the test for now.

[dvyukov]

This sucks. But this allows to move incrementally rather than not move at all (reverting all commits failed on one of the OSes/arches).

[melver]

compiler-rt/test/msan/check-handler.cpp

7 ↗

(On Diff #381991)

It seems that the change is a regression on PPC.

Can we instead not do "Trap()" on PPC, with a comment to get it fixed on PPC?

I don't think anybody will investigate this any time soon.

[dvyukov]

revert the trap instead

[melver]

In D112455#3085008, @dvyukov wrote:

revert the trap instead

This is unfortunate, but probably the right thing for now until someone can explain why PPC is being weird about Trap().

[dvyukov]

compiler-rt/test/msan/check-handler.cpp

7 ↗

(On Diff #381991)

This is likely to be true.

I am going to revert the trap instead.
I've found it also fails on x86 (works if I run a stand-alone binary manually, but fails as part of 'ninja check-msan'). It would be good to figure out what happens, but I don't have time right now and don't want to leave broken bots. Anyway, it's just a debugging aid.

[dvyukov]

Yikes, I had a proper revert commit locally, but 'arc' landed it with the previous subject/description...

[nemanjai]

Just out of curiosity, what does the test case expect? I see mention of Trap() causing a zero vs. non-zero exit code. I don't really follow that since a trap is a void function that doesn't return. But I suppose this is referring to the exit code from the program which I imagine will be something like SIGABRT. Should the invocation of not in the test case just have --crash?

compiler-rt/lib/sanitizer_common/sanitizer_termination.cpp

if (!atomic_compare_exchange_strong(&first_tid, &cmp, tid,
     } else {
       // Another thread fails already, let it print the stack and terminate.
       SleepForSeconds(2);
     }
     Trap();
   }
   if (CheckUnwindCallback)
     CheckUnwindCallback();
-  Trap();
   Die();
 }
 
 } // namespace __sanitizer
 
 using namespace __sanitizer;
 
 extern "C" {
 SANITIZER_INTERFACE_ATTRIBUTE
 void __sanitizer_set_death_callback(void (*callback)(void)) {
   SetUserDieCallback(callback);
 }
 }  // extern "C"