It seems that CHECK terminates the process with 0 status on powerpc64:
https://reviews.llvm.org/D112440#3084251
Disable the test for now.
Details
- Reviewers
vitalybuka melver - Commits
- rGd7b34d0b0db2: msan: disble CHECK test on powerpc64
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
This sucks. But this allows to move incrementally rather than not move at all (reverting all commits failed on one of the OSes/arches).
compiler-rt/test/msan/check-handler.cpp | ||
---|---|---|
7 ↗ | (On Diff #381991) | It seems that the change is a regression on PPC. Can we instead not do "Trap()" on PPC, with a comment to get it fixed on PPC? I don't think anybody will investigate this any time soon. |
This is unfortunate, but probably the right thing for now until someone can explain why PPC is being weird about Trap().
compiler-rt/test/msan/check-handler.cpp | ||
---|---|---|
7 ↗ | (On Diff #381991) | This is likely to be true. I am going to revert the trap instead. |
Yikes, I had a proper revert commit locally, but 'arc' landed it with the previous subject/description...
Just out of curiosity, what does the test case expect? I see mention of Trap() causing a zero vs. non-zero exit code. I don't really follow that since a trap is a void function that doesn't return. But I suppose this is referring to the exit code from the program which I imagine will be something like SIGABRT. Should the invocation of not in the test case just have --crash?