This is an archive of the discontinued LLVM Phabricator instance.

[ARM][libcxxabi] Add PACBTI-M support to libcxxabi
ClosedPublic

Authored by stuij on Oct 25 2021, 3:41 AM.

Details

Summary

This change consists of just adding 'BTI' to the prologue of Arm assembly
functions, which is just the one: __cxa_end_cleanup

This patch is part of a series that adds support for the PACBTI-M extension of
the Armv8.1-M architecture, as detailed here:

https://community.arm.com/arm-community-blogs/b/architectures-and-processors-blog/posts/armv8-1-m-pointer-authentication-and-branch-target-identification-extension

The PACBTI-M specification can be found in the Armv8-M Architecture Reference
Manual:

https://developer.arm.com/documentation/ddi0553/latest

The following people contributed to this patch:

  • Mikhail Maltsev

Diff Detail

Event Timeline

stuij created this revision.Oct 25 2021, 3:41 AM
stuij requested review of this revision.Oct 25 2021, 3:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2021, 3:41 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
lenary accepted this revision.Nov 4 2021, 7:15 AM
danielkiss requested changes to this revision.Dec 1 2021, 3:02 AM
danielkiss added a subscriber: danielkiss.

Cloud you please rebase this patch? there were a few changes to __cxa_end_cleanup recently.

This revision now requires changes to proceed.Dec 1 2021, 3:02 AM
stuij updated this revision to Diff 392676.Dec 8 2021, 1:10 AM

rebased as per review request

danielkiss accepted this revision.Dec 8 2021, 1:19 AM

Thanks for the rebase, LGTM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2021, 1:53 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.