This is an archive of the discontinued LLVM Phabricator instance.

Differential D111755

[ARM] Don't use TARGET_HEADER_BUILTIN in arm_mve_builtins.inc or arm_cde_builtins.inc
ClosedPublic

Authored by craig.topper on Oct 13 2021, 12:57 PM.

Details

Reviewers
simon_tatham
efriedma
miyuki
rnk
Commits
rGc294715e2e0c: [ARM] Don't use TARGET_HEADER_BUILTIN in arm_mve_builtins.inc or…
Summary

The attributes string doesn't include 'f' or 'h'. I don't think
any code looks at the header name without those.

Diff Detail

Unit TestsFailed

TimeTest
21,880 msx64 debian > libarcher.races::task-dependency.c

Event Timeline

craig.topper created this revision.Oct 13 2021, 12:57 PM
Herald added subscribers: dmgreen, kristof.beyls. · View Herald TranscriptOct 13 2021, 12:57 PM
craig.topper requested review of this revision.Oct 13 2021, 12:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2021, 12:57 PM
Harbormaster completed remote builds in B128705: Diff 379509.Oct 13 2021, 1:47 PM
simon_tatham accepted this revision.Oct 15 2021, 2:31 AM
This revision is now accepted and ready to land.Oct 15 2021, 2:31 AM
This revision was landed with ongoing or failed builds.Oct 15 2021, 9:11 AM
Closed by commit rGc294715e2e0c: [ARM] Don't use TARGET_HEADER_BUILTIN in arm_mve_builtins.inc or… (authored by craig.topper). · Explain Why
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rGc294715e2e0c: [ARM] Don't use TARGET_HEADER_BUILTIN in arm_mve_builtins.inc or….

Revision Contents

PathSize
clang/
utils/
TableGen/
8 lines

Diff 379509

clang/utils/TableGen/MveEmitter.cpp

//===- MveEmitter.cpp - Generate arm_mve.h for use with clang -*- C++ -*-=====// //===- MveEmitter.cpp - Generate arm_mve.h for use with clang -*- C++ -*-=====//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
▲ Show 20 Lines • Show All 1,927 Lines • ▼ Show 20 Lines OS << "#ifdef __cplusplus\n"
"#endif\n" "#endif\n"
"\n" "\n"
"#endif /* __ARM_MVE_H */\n"; "#endif /* __ARM_MVE_H */\n";
} }
void MveEmitter::EmitBuiltinDef(raw_ostream &OS) { void MveEmitter::EmitBuiltinDef(raw_ostream &OS) {
for (const auto &kv : ACLEIntrinsics) { for (const auto &kv : ACLEIntrinsics) {
const ACLEIntrinsic &Int = *kv.second; const ACLEIntrinsic &Int = *kv.second;
OS << "TARGET_HEADER_BUILTIN(__builtin_arm_mve_" << Int.fullName() OS << "BUILTIN(__builtin_arm_mve_" << Int.fullName()
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    OS << "BUILTIN(__builtin_arm_mve_" << Int.fullName()
-       << ", \"\", \"n\")\n";
+    OS << "BUILTIN(__builtin_arm_mve_" << Int.fullName() << ", \"\", \"n\")\n";
Lint: Pre-merge checks: clang-format: please reformat the code ``` - OS << "BUILTIN(__builtin_arm_mve_" << Int.
<< ", \"\", \"n\", \"arm_mve.h\", ALL_LANGUAGES, \"\")\n"; << ", \"\", \"n\")\n";
} }
std::set<std::string> ShortNamesSeen; std::set<std::string> ShortNamesSeen;
for (const auto &kv : ACLEIntrinsics) { for (const auto &kv : ACLEIntrinsics) {
const ACLEIntrinsic &Int = *kv.second; const ACLEIntrinsic &Int = *kv.second;
if (Int.polymorphic()) { if (Int.polymorphic()) {
StringRef Name = Int.shortName(); StringRef Name = Int.shortName();
▲ Show 20 Lines • Show All 192 Lines • ▼ Show 20 Lines OS << "#ifdef __cplusplus\n"
"#endif /* __ARM_CDE_H */\n"; "#endif /* __ARM_CDE_H */\n";
} }
void CdeEmitter::EmitBuiltinDef(raw_ostream &OS) { void CdeEmitter::EmitBuiltinDef(raw_ostream &OS) {
for (const auto &kv : ACLEIntrinsics) { for (const auto &kv : ACLEIntrinsics) {
if (kv.second->headerOnly()) if (kv.second->headerOnly())
continue; continue;
const ACLEIntrinsic &Int = *kv.second; const ACLEIntrinsic &Int = *kv.second;
OS << "TARGET_HEADER_BUILTIN(__builtin_arm_cde_" << Int.fullName() OS << "BUILTIN(__builtin_arm_cde_" << Int.fullName()
<< ", \"\", \"ncU\", \"arm_cde.h\", ALL_LANGUAGES, \"\")\n"; << ", \"\", \"ncU\")\n";
} }
} }
void CdeEmitter::EmitBuiltinSema(raw_ostream &OS) { void CdeEmitter::EmitBuiltinSema(raw_ostream &OS) {
std::map<std::string, std::set<std::string>> Checks; std::map<std::string, std::set<std::string>> Checks;
GroupSemaChecks(Checks); GroupSemaChecks(Checks);
for (const auto &kv : Checks) { for (const auto &kv : Checks) {
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines