[OpenMP] libomp: fix warning on comparison of integer expressions of different signedness

[AndreyChurbanov]

Summary

Luke Benes <[e-mail]> reported the warning:

[2685/5155] Building CXX object projects/openmp/runtime/src/CMakeFiles/omp.dir/kmp_settings.cpp.o
/llvm-project/openmp/runtime/src/kmp_settings.cpp: In function ‘void __kmp_check_stksize(size_t*)’:
/llvm-project/openmp/runtime/src/kmp_settings.cpp:305:12: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘long int’ [-Wsign-compare]

305 |   if (*val < KMP_MIN_STKSIZE)

The patch replaces macro with global variable.

[lbenes]

I can confirm this patch does resolve the gcc-11 warning.

[jlpeyton]

LGTM

openmp/runtime/src/kmp_settings.cpp

static void __kmp_stg_parse_bool(char const *name, char const *value,
   }
 } // __kmp_stg_parse_bool
 
 // placed here in order to use __kmp_round4k static function
 void __kmp_check_stksize(size_t *val) {
   // if system stack size is too big then limit the size for worker threads
   if (*val > KMP_DEFAULT_STKSIZE * 16) // just a heuristics...
     *val = KMP_DEFAULT_STKSIZE * 16;
-  if (*val < KMP_MIN_STKSIZE)
-    *val = KMP_MIN_STKSIZE;
+  if (*val < __kmp_sys_min_stksize)
+    *val = __kmp_sys_min_stksize;
   if (*val > KMP_MAX_STKSIZE)
     *val = KMP_MAX_STKSIZE; // dead code currently, but may work in future
 #if KMP_OS_DARWIN
   *val = __kmp_round4k(*val);
 #endif // KMP_OS_DARWIN
 }
 
 static void __kmp_stg_parse_size(char const *name, char const *value,