Page MenuHomePhabricator

lbenes (Luke Benes)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2016, 2:53 AM (371 w, 4 d)

Recent Activity

Dec 26 2021

lbenes added a reviewer for D115830: [profile] Fix writing binary id into profiles: davidxl.
Dec 26 2021, 6:56 AM · Restricted Project

Dec 23 2021

lbenes accepted D115830: [profile] Fix writing binary id into profiles.
Dec 23 2021, 4:20 AM · Restricted Project

Dec 18 2021

lbenes added a comment to D115830: [profile] Fix writing binary id into profiles.

This patch fixes the 2 failing tests on openSUSE Tumbleweed. Thanks gulfem!

Dec 18 2021, 8:31 AM · Restricted Project

Dec 16 2021

lbenes added a comment to D115842: [llvm-profgen] Fix warning of enumerated and non-enumerated type in conditional expression.

This patch resolves the warning on gcc-11. Thanks wlei!

Dec 16 2021, 4:59 AM · Restricted Project

Dec 11 2021

lbenes added a comment to D115589: [adt] Fix compiler warning in test.

See commit d79bb30dbb08910816859ccaae1ca5d04fbd9501

This avoids a -pedantic warning:
warning: ISO C++11 requires at least one argument for the "..." in a variadic macro
Dec 11 2021, 6:49 PM · Restricted Project

Dec 10 2021

lbenes added a comment to D113798: Add loop unrolling and peeling preferences for RISCV.

A branch containing this patch was accidentally pushed to GitHub: https://github.com/llvm/llvm-project/tree/arcpatch-D113798

Dec 10 2021, 10:43 AM · Restricted Project

Nov 6 2021

lbenes requested review of D113346: [IR][ShuffleVector] Fix Wdangling-else warning in InstructionsTest.
Nov 6 2021, 8:49 AM · Restricted Project

Nov 5 2021

lbenes added a comment to D112590: [lld][WebAssebmly] Convert tests to use disassembly. NFC.

A branch containing this patch was accidentally pushed to GitHub: https://github.com/llvm/llvm-project/tree/efb284c07e

Nov 5 2021, 5:48 PM · Restricted Project

Oct 18 2021

lbenes updated the summary of D112044: [DebugInfo][InstrRef] Fix Wdangling-else warning in InstrRefLDVTest.
Oct 18 2021, 5:55 PM · Restricted Project
lbenes updated the summary of D112044: [DebugInfo][InstrRef] Fix Wdangling-else warning in InstrRefLDVTest.
Oct 18 2021, 5:53 PM · Restricted Project
lbenes requested review of D112044: [DebugInfo][InstrRef] Fix Wdangling-else warning in InstrRefLDVTest.
Oct 18 2021, 5:52 PM · Restricted Project

Oct 12 2021

lbenes added a comment to D111562: [OpenMP] libomp: fix warning on comparison of integer expressions of different signedness.

I can confirm this patch does resolve the gcc-11 warning.

Oct 12 2021, 7:21 PM · Restricted Project

Sep 22 2021

lbenes added a reviewer for D110283: [ADT] Add trailing comma on TYPED_TEST_SUITE: bkramer.
Sep 22 2021, 5:09 PM · Restricted Project
lbenes updated the summary of D110283: [ADT] Add trailing comma on TYPED_TEST_SUITE.
Sep 22 2021, 5:01 PM · Restricted Project
lbenes requested review of D110283: [ADT] Add trailing comma on TYPED_TEST_SUITE.
Sep 22 2021, 12:52 PM · Restricted Project

Aug 13 2021

lbenes added a comment to D108000: [IFS] Fix copy constructor warnings in IFSStub.cpp.

LGTM With gcc-11, I no longer see the warning messages.

Aug 13 2021, 6:37 AM · Restricted Project

Jul 19 2021

lbenes added a comment to D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux.

LGTM. No more test failures or build errors. And the libreoffice .configure error has been resolved now too. Thanks!

Jul 19 2021, 11:04 PM · Restricted Project

Jul 17 2021

lbenes added a comment to D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux.

Updated OpenSUSE which bumped gcc from 10 to 11. Still failing with the latest patch.

Jul 17 2021, 9:05 PM · Restricted Project

Jul 16 2021

lbenes added a comment to D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux.

Still seeing the same failure on OpenSUSE. I'm still on gcc 10.3. Should I need to upgrade for this to work?

Jul 16 2021, 9:25 PM · Restricted Project
lbenes added a comment to D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux.

This one should work.
https://controlc.com/505d58d3

Jul 16 2021, 5:12 PM · Restricted Project
lbenes added a comment to D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux.

Thanks for looking into this. On OpenSUSE i686, the failing tests are now fixed, but Driver/linux-cross.cpp fails with:

Jul 16 2021, 1:47 PM · Restricted Project

May 19 2021

lbenes requested review of D102792: Fix warning: comparison of integer expressions of different signedness.
May 19 2021, 11:46 AM · Restricted Project

Feb 26 2021

lbenes added a comment to D97490: [WebAssembly] Avoid `bit_cast` when printing f32 and f64 immediates.

I can confirm that this patch fixes the failing immediates.ll test on x86 built by gcc 10.

Feb 26 2021, 12:49 PM · Restricted Project

Sep 11 2020

lbenes added a comment to D87409: [libTooling] Fix use of `char` in comparison..

I can confirm that this commit fixes the Wtype-limits warning when built on Raspbian armhf.

Sep 11 2020, 10:26 AM · Restricted Project

Jul 16 2020

lbenes added a comment to D83898: [ms] [llvm-ml] Remove unused function.

I can confirm that gcc 10.1.1 no longer warns after this patch is applied. This fixes the issue for me.

Jul 16 2020, 7:51 PM · Restricted Project

Feb 16 2020

lbenes added a comment to D74666: Prevent gcc from issuing a warning upon coffnamecpy.

I can confirm that this patch does silence the warning on gcc 9.2.

Feb 16 2020, 11:01 PM · Restricted Project