[Clang][NFC] Fix multiline comment prefixes in function headers

[saiislam]

Summary

Cleanup of D105191 after latest clang-format changes.

[thakis]

clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp

134–135

The usual style for "named parameters" in LLVm is

AddStaticDeviceLibsLinking(C, *this, JA, Inputs, Args, CmdArgs, "amdgcn",
                           SubArchName, /*isBitCodeSDL=*/true, /*postClangLink=*/false);

[MyDeveloperDay]

what @thakis said, this isn't normally my area but this is one of the files that has reverted its "clang-format clean" status with recent commits.

[saiislam]

Used comment style for named parameters.

[MyDeveloperDay]

To me you should be doing

/*bitcode SDL=*/true

It looks like its still failing clang-format might I suggest making the changes to the comment, git adding the file then doing

git clang-format

This will clang-format your staged files.

[saiislam]

Updated comments as per suggestion. Apologies for the delay.

[MyDeveloperDay]

Nit: That is more correct, but actually, you normally make the comment match the param name (I think there might even be a clang-tidy check for that?)

i.e.

/*isBitCodeSDL=*/

[saiislam]

In D111545#3218961, @MyDeveloperDay wrote:

Nit: That is more correct, but actually, you normally make the comment match the param name (I think there might even be a clang-tidy check for that?)

i.e.

/*isBitCodeSDL=*/

Thanks. I fixed it while committing.

clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp

if (HasLibm) {
           AMDGPUOpenMPTC.getCommonDeviceLibNames(Args, SubArchName.str());
       llvm::for_each(BCLibs, [&](StringRef BCFile) {
         CmdArgs.push_back(Args.MakeArgString(BCFile));
       });
     }
   }
 
   AddStaticDeviceLibsLinking(C, *this, JA, Inputs, Args, CmdArgs, "amdgcn",
-                      SubArchName,
-                      /* bitcode SDL?*/ true,
-                      /* PostClang Link? */ false);
+                             SubArchName, /*isBitCodeSDL=*/true,
+                             /*postClangLink=*/false);
   // Add an intermediate output file.
   CmdArgs.push_back("-o");
   const char *OutputFileName =
       getOutputFileName(C, OutputFilePrefix, "-linked", "bc");
   CmdArgs.push_back(OutputFileName);
   const char *Exec =
       Args.MakeArgString(getToolChain().GetProgramPath("llvm-link"));
   C.addCommand(std::make_unique<Command>(

clang/lib/Driver/ToolChains/Cuda.cpp

if (!II.isFilename())
       continue;
 
     const char *CubinF = C.addTempFile(
         C.getArgs().MakeArgString(getToolChain().getInputFilename(II)));
 
     CmdArgs.push_back(CubinF);
   }
 
-  AddStaticDeviceLibsLinking(C, *this, JA, Inputs, Args, CmdArgs, "nvptx", GPUArch,
-                      false, false);
+  AddStaticDeviceLibsLinking(C, *this, JA, Inputs, Args, CmdArgs, "nvptx",
+                             GPUArch, /*isBitCodeSDL=*/false,
+                             /*postClangLink=*/false);
 
   // Find nvlink and pass it as "--nvlink-path=" argument of
   // clang-nvlink-wrapper.
   CmdArgs.push_back(Args.MakeArgString(
       Twine("--nvlink-path=" + getToolChain().GetProgramPath("nvlink"))));
 
   const char *Exec =
       Args.MakeArgString(getToolChain().GetProgramPath("clang-nvlink-wrapper"));
if (DeviceOffloadingKind == Action::OFK_OpenMP) {
     if (DriverArgs.hasFlag(options::OPT_fopenmp_target_new_runtime,
                            options::OPT_fno_openmp_target_new_runtime, true))
       BitcodeSuffix = "new-nvptx-" + GpuArch.str();
     else
       BitcodeSuffix = "nvptx-" + GpuArch.str();
 
     addOpenMPDeviceRTL(getDriver(), DriverArgs, CC1Args, BitcodeSuffix,
                        getTriple());
-    AddStaticDeviceLibsPostLinking(getDriver(), DriverArgs, CC1Args, "nvptx", GpuArch,
-                        /* bitcode SDL?*/ true, /* PostClang Link? */ true);
+    AddStaticDeviceLibsPostLinking(getDriver(), DriverArgs, CC1Args, "nvptx",
+                                   GpuArch, /*isBitCodeSDL=*/true,
+                                   /*postClangLink=*/true);
   }
 }
 
 llvm::DenormalMode CudaToolChain::getDefaultDenormalModeForType(
     const llvm::opt::ArgList &DriverArgs, const JobAction &JA,
     const llvm::fltSemantics *FPType) const {
   if (JA.getOffloadingDeviceKind() == Action::OFK_Cuda) {
     if (FPType && FPType == &llvm::APFloat::IEEEsingle() &&