This is an archive of the discontinued LLVM Phabricator instance.

X86Vector: relax checks in rsqrt's integration test
ClosedPublic

Authored by cota on Oct 8 2021, 1:14 PM.

Details

Summary

Instead of hard-coding results for both Intel and AMD, let's relax
the checks to simplify the test while supporting both implementations.
Note that:

  • If a new hardware implementation comes up in the future, it is likely to pass the relaxed tests, i.e. no future maintenance burden for us.
  • If something terribly wrong happens (e.g. instead of rsqrt we execute 1/sqrt), the tests will probably catch it, since the relaxed tests expect low precision (e.g. rsqrt(1) != 1.0).

Diff Detail

Event Timeline

cota created this revision.Oct 8 2021, 1:14 PM
cota requested review of this revision.Oct 8 2021, 1:14 PM
aartbik accepted this revision.Oct 8 2021, 1:17 PM

Welcome back old friend!

This revision is now accepted and ready to land.Oct 8 2021, 1:17 PM
cota edited the summary of this revision. (Show Details)Oct 8 2021, 1:17 PM
cota edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.